Skip to content

Commit

Permalink
ORC-1837: Remove commons-csv from parent pom.xml
Browse files Browse the repository at this point in the history
### What changes were proposed in this pull request?

This PR aims to remove `commons-csv` from parent `pom.xml`.

### Why are the changes needed?

We can remove `commons-csv` from the parent pom file.

- `commons-cvs` is used in `bench` module only and it's defined in `pom.xml` of `bench` module already.
- `opencsv` is used in `tools`

```
$ git grep csv | grep import
bench/core/src/java/org/apache/orc/bench/core/convert/GenerateVariants.java:import org.apache.orc.bench.core.convert.csv.CsvReader;
bench/core/src/java/org/apache/orc/bench/core/convert/csv/CsvReader.java:import org.apache.commons.csv.CSVFormat;
bench/core/src/java/org/apache/orc/bench/core/convert/csv/CsvReader.java:import org.apache.commons.csv.CSVParser;
bench/core/src/java/org/apache/orc/bench/core/convert/csv/CsvReader.java:import org.apache.commons.csv.CSVRecord;
tools/src/java/org/apache/orc/tools/convert/CsvReader.java:import com.opencsv.CSVParser;
tools/src/java/org/apache/orc/tools/convert/CsvReader.java:import com.opencsv.CSVParserBuilder;
tools/src/java/org/apache/orc/tools/convert/CsvReader.java:import com.opencsv.CSVReader;
tools/src/java/org/apache/orc/tools/convert/CsvReader.java:import com.opencsv.CSVReaderBuilder;
tools/src/java/org/apache/orc/tools/convert/CsvReader.java:import com.opencsv.exceptions.CsvValidationException;
```

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #2114 from dongjoon-hyun/ORC-1837.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
  • Loading branch information
dongjoon-hyun committed Jan 14, 2025
1 parent 94090e0 commit 0456efa
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions java/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -162,11 +162,6 @@
<artifactId>zstd-jni</artifactId>
<version>${zstd-jni.version}</version>
</dependency>
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-csv</artifactId>
<version>1.12.0</version>
</dependency>
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-client-api</artifactId>
Expand Down

0 comments on commit 0456efa

Please sign in to comment.