Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python requests 2.31.0. #5487

Merged
merged 1 commit into from
May 23, 2024
Merged

Use python requests 2.31.0. #5487

merged 1 commit into from
May 23, 2024

Conversation

falkzoll
Copy link
Contributor

Use python requests 2.31.0.

Description

  • The previously installed requests==2.10.0 did not met the docker==4.0.2 requirements. Because of this pip always installed the latest version of requests when installing docker==4.0.2 (see ansible/roles/prereq/tasks/deploy.yml). This worked fine until requests==2.32.2 was latest version available and installed. This version contained changes which made docker==4.0.2 package to fail with for example: "Error connecting: Error while fetching server API version: Not supported URL scheme http+docker". This caused the deployment step to fail the build.

  • Installing requests==2.31.0 now avoids that the install of docker==4.0.2 updates to the latest requests and makes the builds successful again

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

- The previously installed requests==2.10.0 did not met the docker==4.0.2 requirements. Because of this pip always installed the latest version of requests when installing docker==4.0.2. This worked fine until requests==2.32.2 was installed. This version contained changes which made docker==4.0.2 package to fail with for example: "Error connecting: Error while fetching server API version: Not supported URL scheme http+docker". Installing requests==2.31.0 now avoids that the install of docker==4.0.2 updates to the latest requests.
Copy link
Member

@Luke-Roy-IBM Luke-Roy-IBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM THX

@Luke-Roy-IBM Luke-Roy-IBM merged commit 03a785c into apache:master May 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants