-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing include and exclude in zip action #991
Conversation
@@ -649,7 +649,7 @@ func (dm *YAMLParser) readActionFunction(manifestFilePath string, manifestFileNa | |||
|
|||
if utils.IsDirectory(actionFilePath) { | |||
zipFileName = actionFilePath + "." + runtimes.ZIP_FILE_EXTENSION | |||
err := utils.NewZipWritter(actionFilePath, zipFileName).Zip() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason this is called "Writter" and not 'Writer" ?
@@ -649,7 +649,7 @@ func (dm *YAMLParser) readActionFunction(manifestFilePath string, manifestFileNa | |||
|
|||
if utils.IsDirectory(actionFilePath) { | |||
zipFileName = actionFilePath + "." + runtimes.ZIP_FILE_EXTENSION | |||
err := utils.NewZipWritter(actionFilePath, zipFileName).Zip() | |||
err := utils.NewZipWritter(actionFilePath, zipFileName, action.Include, action.Exclude, filepath.Dir(manifestFilePath)).Zip() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good, this keeps a pipeline concept going for the future...
@@ -0,0 +1,152 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for splitting out this module.
Use the new include in the wskdeploy manifest to avoid code duplication. The new functionality is implemented and spec at apache/openwhisk-wskdeploy#991
I was following your article at medium - |
@musa-pro @pritidesai Hi Mohammad, If you believe there is a bug in the utility, please open an issue and include your manifest contents and any other config. info (.wskconfig file for example). It is not customary to comment on merged PRs and expect any action to be taken. In addition, I am not sure how old the blog is, but there are testcases within the repo. that test this functionality with every change to the code. You can likely find one or more within the https://github.com/apache/openwhisk-wskdeploy/tree/master/tests/src/integration directory structure. |
Closes #991
include
andexclude
in zip action:For the directory structure:
Exclude Use Case:
For the directory structure:
Added two integration test
zipactionwithinclude
andzipactionwithexclude
.