Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rust extension to list of known runtimes #1117

Merged
merged 1 commit into from
Feb 18, 2021
Merged

Add Rust extension to list of known runtimes #1117

merged 1 commit into from
Feb 18, 2021

Conversation

mrutkows
Copy link
Contributor

Trying to fix #1116 but with a clean commit history.

@mrutkows mrutkows requested a review from pritidesai February 18, 2021 05:40
pritidesai
pritidesai reviewed Feb 18, 2021
View reviewed changes
runtimes/runtimes.go
@@ -43,6 +43,7 @@ const (
PHP_FILE_EXTENSION = "php"
ZIP_FILE_EXTENSION = "zip"
RUBY_FILE_EXTENSION = "rb"
RUST_FILE_EXTENSION = "rs"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we expect rlib as well?

pritidesai
pritidesai approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@pritidesai pritidesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mrutkows 👍

@pritidesai pritidesai merged commit ee2db4c into apache:master Feb 18, 2021
@mrutkows mrutkows deleted the rusty branch February 23, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pritidesai pritidesai pritidesai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrutkows @pritidesai