-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support array result include sequence action #120
Support array result include sequence action #120
Conversation
The steps of test
[root@nccddev130026 workspace]# cat ~/split.php
<?php
function main(array $args) : array
{
$payload = $args["payload"] ?? "aaaa\nbbbbb\ncccccc";
$separator = $args["separator"] ?? "\n";
$result = explode($separator,$payload);
return $result;
}
[root@nccddev130026 workspace]# cat ~/sort.php
<?php
function main(array $args) : array
{
$result = array_reverse($args);
return $result;
}
|
d58c0b6
to
96ba90a
Compare
|
||
val (runCode, runRes) = c.run(runPayload(JsObject())) | ||
runCode should be(200) | ||
runRes shouldBe Some(JsObject("0" -> JsString("a"), "1" -> JsString("b"))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems php is special, it will return JsObject with index(0, 1, 2....N+1) when php codes return array.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Depend on below prs:
Support array result for common action and sequence action openwhisk#5290 (already merged)
Support array result include sequence action openwhisk-runtime-go#170 (already merged)
Support array result