Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENNLP-1226: Training an NER model for dates with 'dd.mm.yyyy' as Date format #678

Merged

Conversation

mawiesne
Copy link
Contributor

@mawiesne mawiesne commented Nov 1, 2024

Change

  • adds NameFinderMEWithDatesTest verifying German (and English) date formats, via custom training data per language, as reproducer for OpenNLP-1226
  • adds RandomGermanNewsGenerator to generate synthetic news corpora with dates annotated, typical for DE locale
  • adds RandomEnglishNewsGenerator to generate synthetic news corpora with dates annotated, typical for EN,US/UK/AUS locale
  • extracts code to AbstractNameFinderTest to avoid cnp of re-usable code

Tasks

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.

@mawiesne mawiesne requested review from kinow, jzonthemtn and rzo1 November 1, 2024 09:26
@mawiesne mawiesne self-assigned this Nov 1, 2024
@mawiesne
Copy link
Contributor Author

mawiesne commented Nov 1, 2024

Will fix deprecation violation(s) after I had breakfast. 🙂

…e format

- adds NameFinderMEWithDatesTest verifying German (and English) date formats, via custom training data per language, as reproducer for OpenNLP-1226
- adds RandomGermanNewsGenerator to generate synthetic news corpora with dates annotated, typical for DE locale
- adds RandomEnglishNewsGenerator to generate synthetic news corpora with dates annotated, typical for EN,US/UK/AUS locale
- extracts code to AbstractNameFinderTest to avoid cnp of re-usable code
@mawiesne mawiesne force-pushed the OPENNLP-1226-training-NER-models-for-different-date-formats branch from f5d026a to 3bcd13a Compare November 1, 2024 10:27
@mawiesne mawiesne changed the title OPENNLP-1226 Training an NER model for dates with 'dd.mm.yyyy' as Date format OPENNLP-1226: Training an NER model for dates with 'dd.mm.yyyy' as Date format Nov 1, 2024
@rzo1 rzo1 merged commit a5b1b62 into main Nov 5, 2024
14 checks passed
@rzo1 rzo1 deleted the OPENNLP-1226-training-NER-models-for-different-date-formats branch November 5, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants