Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENNLP-1631 Convert existing ModelLoader tests to integration tests #674

Conversation

mawiesne
Copy link
Contributor

Change

  • converts the three existing test classes to "IT" ending so that they get executed during failsafe plugin phase
  • adds new 18 languages for each model type (sent, pos, tokens)
  • fixes missing language checks for "nl" (Dutch) in DownloadParserTest

Tasks

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.

- converts the three existing test classes to "IT" ending so that they get executed during failsafe plugin phase
- adds new 18 languages for each model type (sent, pos, tokens)
- fixes missing language checks for "nl" (Dutch) in DownloadParserTest
@mawiesne mawiesne added the java Pull requests that update Java code label Oct 29, 2024
@mawiesne mawiesne requested review from kinow, jzonthemtn and rzo1 October 29, 2024 06:44
@mawiesne mawiesne self-assigned this Oct 29, 2024
@rzo1 rzo1 merged commit 74c7d52 into main Oct 29, 2024
14 checks passed
@mawiesne mawiesne deleted the OPENNLP-1631-Convert-existing-ModelLoader-tests-to-integration-tests branch October 31, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants