Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to v0.51.0 rc1 #5413

Merged
merged 3 commits into from
Dec 14, 2024
Merged

Bump version to v0.51.0 rc1 #5413

merged 3 commits into from
Dec 14, 2024

Conversation

Zheaoli
Copy link
Member

@Zheaoli Zheaoli commented Dec 13, 2024

Which issue does this PR close?

Part of #5412

What changes are included in this PR?

Name Version Next
core 0.50.2 0.51.0
integrations/cloud_filter 0.0.3 0.0.4
integrations/compat 1.0.1 1.0.2
integrations/dav-server 0.2.2 0.2.3
integrations/fuse3 0.0.9 0.0.10
integrations/object_store 0.48.2 0.48.3
integrations/parquet 0.2.2 0.2.3
integrations/spring - -
integrations/unftp-sbe 0.0.9 0.0.10
integrations/virtiofs - -
bin/oay 0.41.13 0.41.14
bin/ofs 0.0.14 0.0.15
bin/oli 0.41.13 0.41.14
bindings/c 0.45.1 0.45.2
bindings/cpp 0.45.13 0.45.14
bindings/dotnet 0.1.11 0.1.12
bindings/go 0.1.4 0.1.5
bindings/haskell 0.44.13 0.44.14
bindings/java 0.47.5 0.47.6
bindings/lua 0.1.11 0.1.12
bindings/nodejs 0.47.7 0.47.8
bindings/ocaml - -
bindings/php 0.1.11 0.1.12
bindings/python 0.45.12 0.45.13
bindings/ruby 0.1.11 0.1.12
bindings/swift - -
bindings/zig - -

Signed-off-by: Manjusaka <[email protected]>
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Zheaoli, thank you for creating this. It looks great to me overall, except for some incorrect version bumps.

@@ -25,7 +25,7 @@ homepage = "https://opendal.apache.org/"
license = "Apache-2.0"
repository = "https://github.com/apache/opendal"
rust-version = "1.75"
version = "0.45.1"
version = "0.46.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to bump this? It seems there are no breaking changes for C and C++.

@@ -18,7 +18,7 @@
[package]
name = "opendal-dotnet"
publish = false
version = "0.1.11"
version = "0.2.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same.

@@ -25,7 +25,7 @@ homepage = "https://opendal.apache.org/"
license = "Apache-2.0"
repository = "https://github.com/apache/opendal"
rust-version = "1.75"
version = "0.44.13"
version = "0.45.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same. We only need to bump it when breaking changes happen.

@@ -25,7 +25,7 @@ homepage = "https://opendal.apache.org/"
license = "Apache-2.0"
repository = "https://github.com/apache/opendal"
rust-version = "1.75"
version = "0.47.5"
version = "0.48.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same.

@@ -18,7 +18,7 @@
[package]
name = "opendal-lua"
publish = false
version = "0.1.11"
version = "0.2.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same.

@@ -25,7 +25,7 @@ homepage = "https://opendal.apache.org/"
license = "Apache-2.0"
repository = "https://github.com/apache/opendal"
rust-version = "1.75"
version = "0.47.7"
version = "0.48.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same.

@@ -18,7 +18,7 @@
[package]
name = "opendal-php"
publish = false
version = "0.1.11"
version = "0.2.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same.

@@ -25,7 +25,7 @@ homepage = "https://opendal.apache.org/"
license = "Apache-2.0"
repository = "https://github.com/apache/opendal"
rust-version = "1.75"
version = "0.45.12"
version = "0.46.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same.

@@ -18,7 +18,7 @@
[package]
name = "opendal-ruby"
publish = false
version = "0.1.11"
version = "0.2.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same.

@Zheaoli
Copy link
Member Author

Zheaoli commented Dec 14, 2024

It looks great to me overall, except for some incorrect version bumps.

For me, when the core is in a new big version. I prefer upgrade the binding to a new big version at the same time. This is a personal style. On your call.

@Xuanwo
Copy link
Member

Xuanwo commented Dec 14, 2024

For me, when the core is in a new big version. I prefer upgrade the binding to a new big version at the same time. This is a personal style. On your call.

Core changes should always be hidden from binding users. So let's just bump patch versions unless the binding itself has breaking changes.

Signed-off-by: Manjusaka <[email protected]>
@Zheaoli
Copy link
Member Author

Zheaoli commented Dec 14, 2024

@Xuanwo PTAL

@Zheaoli Zheaoli requested a review from Xuanwo December 14, 2024 14:34
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

@Zheaoli Zheaoli merged commit 60281a0 into main Dec 14, 2024
262 checks passed
@Zheaoli Zheaoli deleted the manjusaka/bump-version branch December 14, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants