chore: fix cargo clippy #5379
Merged
chore: fix cargo clippy #5379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meteorgan
force-pushed
the
clippy_issues
branch
from
3b33103 to
e1ee58e
Compare
Xuanwo
approved these changes
Dec 2, 2024
|
Hi @meteorgan, it seems the clippy lints haven't been fully resolved. Could you take another look at them? |
Okay. I found them late last night. I'll submit another PR soon |
|
@meteorgan You could directly run the following command, so nothing will be missed. |
Thanks. I'll give it a try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None
Rationale for this change
Rust has been to upgraded to 1.83.0, which has caused some issues related to Clippy. such as:
https://github.com/apache/opendal/actions/runs/12097756740/job/33733480298?pr=5370
https://github.com/apache/opendal/actions/runs/12097756774/job/33733479648?pr=5370
https://github.com/apache/opendal/actions/runs/12097756741/job/33733480352?pr=5370
What changes are included in this PR?
Are there any user-facing changes?