Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/layers): add correctness_check and capability_check layer to verify whether the operation and arguments is supported #5352

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

meteorgan
Copy link
Contributor

Which issue does this PR close?

Closes #5219

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@meteorgan
Copy link
Contributor Author

Failed to download hadoop-3.3.5.tar.gz again. I'm going to add it to the cache.

@meteorgan meteorgan force-pushed the capability_check_layer branch from 81e192f to bdd80dd Compare November 25, 2024 13:19
@meteorgan meteorgan marked this pull request as ready for review November 25, 2024 13:47
@meteorgan meteorgan requested a review from Xuanwo as a code owner November 25, 2024 13:47
@meteorgan meteorgan force-pushed the capability_check_layer branch 2 times, most recently from e542168 to 98ead1e Compare December 3, 2024 12:58
@meteorgan meteorgan changed the title feat(core/layers): add capability_check layer to check whether the operation is supported by the underlying service feat(core/layers): add correctness_check and capability_check layer to verify whether the operation and arguments is supported Dec 3, 2024
@meteorgan meteorgan force-pushed the capability_check_layer branch from 98ead1e to e7f0a81 Compare December 4, 2024 04:55
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @meteorgan for working on this!

core/src/layers/correctness_check.rs Outdated Show resolved Hide resolved
core/src/layers/correctness_check.rs Outdated Show resolved Hide resolved
core/src/layers/correctness_check.rs Outdated Show resolved Hide resolved
core/src/layers/correctness_check.rs Outdated Show resolved Hide resolved
core/src/layers/correctness_check.rs Outdated Show resolved Hide resolved
core/src/layers/capability_check.rs Outdated Show resolved Hide resolved
core/src/layers/capability_check.rs Outdated Show resolved Hide resolved
core/src/layers/capability_check.rs Outdated Show resolved Hide resolved
core/src/layers/capability_check.rs Outdated Show resolved Hide resolved
core/src/layers/complete.rs Outdated Show resolved Hide resolved
@meteorgan meteorgan force-pushed the capability_check_layer branch from 3507309 to e169e41 Compare December 4, 2024 15:06
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @meteorgan for working for this!

@Xuanwo
Copy link
Member

Xuanwo commented Dec 5, 2024

Hi @meteorgan, I've been trying to contact you using the email address listed on your GitHub profile. Could you please check it?

@Xuanwo Xuanwo merged commit f3bf1d4 into apache:main Dec 5, 2024
239 checks passed
@meteorgan
Copy link
Contributor Author

Hi @meteorgan, I've been trying to contact you using the email address listed on your GitHub profile. Could you please check it?

Sorry for the late reply, I've already responded to the email. and thank you for the invitation !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CapabilityCheckLayer
2 participants