-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(integrations/spring): add spring project module #4988
Conversation
c5fe039
to
be765f0
Compare
Thanks a lot for the PR. I'll get to this after OpenDAL 0.49 is released. |
integrations/spring/README.md
Outdated
@@ -0,0 +1 @@ | |||
# Spring OpenDAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refer to the other README files to add some basic information about this integration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to call it "Apache OpenDAL Spring Integrations". Or in details like "Apache OpenDAL Spring Boot Starter".
This follow the name conventions that a thrid party plugin name as <third-party>-spring-xxx
.
integrations/spring/pom.xml
Outdated
<modelVersion>4.0.0</modelVersion> | ||
|
||
<groupId>org.apache.opendal</groupId> | ||
<artifactId>spring-opendal-parent</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I take a look over spring-boot-starter-data-redis
and found that they are in three artifactId
:
spring-data-redis
spring-boot-starter-data-redis
spring-boot-starter-data-redis-reactive
Should we follow the same pattern that have three artifact
instead of module
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Xuanwo I think you may misunderstand module and artifactId's definition. Every library has an artifactId, which is the smallest unit of reference. Some libraries are responsible for managing other libraries and do not directly contain code themselves; they use a to manage modules or sub-projects (in Maven 4.0, these will be referred to as sub-projects instead of modules).
integrations/spring/pom.xml
Outdated
<version>0.0.1-SNAPSHOT</version> | ||
<packaging>pom</packaging> | ||
<modules> | ||
<module>spring-opendal</module> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about spring-data-opendal
? I'm guessing it's different with spring-opendal
?
integrations/spring/pom.xml
Outdated
<packaging>pom</packaging> | ||
<modules> | ||
<module>spring-opendal</module> | ||
<module>spring-starter-opendal</module> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about spring-boot-starter-data-opendal
?
integrations/spring/pom.xml
Outdated
<modules> | ||
<module>spring-opendal</module> | ||
<module>spring-starter-opendal</module> | ||
<module>spring-starter-opendal-reactive</module> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about spring-boot-starter-data-opendal-reactive
?
integrations/spring/pom.xml
Outdated
</dependency> | ||
<dependency> | ||
<groupId>org.apache.opendal</groupId> | ||
<artifactId>opendal-java</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be opendal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Xuanwo Fixed
be765f0
to
0ab4326
Compare
I hope that in the end we use the following naming convention:
Reasons:
Let me know if there's anything wrong. |
Signed-off-by: ZhangJian He <[email protected]>
0ab4326
to
e7628d3
Compare
Hi, it looks good to me to remove |
Yes. Let me push a follow up and merge this. |
Signed-off-by: tison <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
<parent> | ||
<groupId>org.springframework.boot</groupId> | ||
<artifactId>spring-boot-dependencies</artifactId> | ||
<version>${spring-boot.version}</version> | ||
</parent> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I'd prefer to use dependency management rather than inherit from spring boot, as in https://docs.spring.io/spring-boot/maven-plugin/using.html#using.import
But this is OK for now.
@Xuanwo Sorry, It was a typo, |
Rationale for this change
Related to #4756
See more context in https://lists.apache.org/thread/13fhp5s2lrbpgdl129gt7zbpd3gms8bb
What changes are included in this PR?