-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bindings/python): build and publish aarch64 and armv7l wheels #3325
Conversation
5d022c3
to
e957280
Compare
PR failed for #3326, I'm working on this. |
Seems we are still building x86_64: https://github.com/apache/incubator-opendal/actions/runs/6549011611/job/17784998166?pr=3325 📦 Built wheel for CPython 3.9 to dist/opendal-0.41.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
Compiling pyo3-build-config v0.19.2
Compiling pyo3-ffi v0.19.2
Compiling pyo3 v0.19.2
Compiling pyo3-asyncio v0.19.0
Compiling opendal-python v0.41.0 (/home/runner/work/incubator-opendal/incubator-opendal/bindings/python)
Finished release [optimized] target(s) in 27.79s Maybe we should pass |
Oops, forgot to do that. |
e957280
to
8cfee2e
Compare
Ok, why are we depending on ring 0.17? rustls doesn't have a release with ring 0.17 support yet I think? |
Hmm, we have duplicate ring dependencies: $ cargo tree -i ring
error: There are multiple `ring` packages in your project, and the specification `ring` is ambiguous.
Please re-run this command with `-p <spec>` where `<spec>` is one of the following:
[email protected]
[email protected]
$ cargo tree -i [email protected]
ring v0.17.4
└── jsonwebtoken v9.0.0
└── reqsign v0.14.2
└── opendal v0.41.0 (/Users/messense/Projects/opendal/core) |
Yes, we're waiting for other dependencies such as |
Yes, but how does this impact rustls? We have other dependencies that rely directly on |
It's not ideal to have duplication for such crucial crypto dependency, we should wait for the ecosystem to upgrade before doing our upgrade. Besides, the manylinux GCC cross compilers seems to have some issues with ring 0.17 namely |
Thanks for the explanation! |
Probably because GCC 4.8.5 is too old to fully support ACLE. 😂 https://boringssl.googlesource.com/boringssl/+/HEAD/BUILDING.md#build-prerequisites
|
7eff524
to
485b17d
Compare
Fixed, see https://github.com/apache/incubator-opendal/actions/runs/6549415727?pr=3325 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Test run: https://github.com/apache/incubator-opendal/actions/runs/6549415727?pr=3325
Closes #3311 cc @Zheaoli