refactor(bindings/C): Implement error with error message #3250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
\cc @jiaoew1991 Is this kind of error message expected for you? Feel free to raise any comment on this. |
|
Note that the changes in this PR will break the CI of other bindings depending on C binding, i.e. Swift and Zig. (Go currently do not have a CI so it is fine, but it probably will break as well). |
xyjixyjixyji
changed the title
Xuanwo
reviewed
Oct 10, 2023
It would be better for us to address them simultaneously in this PR. I can take a look at zig. |
xyjixyjixyji
force-pushed
the
refactor_error
branch
from
1ee5f58 to
a3b4ea4
Compare
xyjixyjixyji
force-pushed
the
refactor_error
branch
from
a3b4ea4 to
9490b37
Compare
|
\cc @Xuanwo , thanks for the review, the suggestions are good and are adopted accordingly. |
|
We don't need labels for PR. |
Signed-off-by: Xuanwo <[email protected]>
|
I have fixed zig support, the next is swift. |
Signed-off-by: Xuanwo <[email protected]>
|
Go support also fixed, next one is swift. |
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Xuanwo
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the error with error code and error message
Implement opendal_result_operator_new(), now this function returns internal error message.
Refactor the tests and examples to use the above implementations.
This PR seems large, but the essence of it is to add an error message into the opendal_error. Other changes are following this feature.
Close #3244