Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Enable nextest for all behavior tests #2400

Merged
merged 14 commits into from
Jun 2, 2023
Merged

ci: Enable nextest for all behavior tests #2400

merged 14 commits into from
Jun 2, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jun 2, 2023

No description provided.

Xuanwo added 5 commits June 2, 2023 14:06
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Xuanwo added 6 commits June 2, 2023 15:18
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo requested a review from xyjixyjixyji June 2, 2023 08:17
@Xuanwo
Copy link
Member Author

Xuanwo commented Jun 2, 2023

Let's make this PR the first one for @Ji-Xinyou to review as a committer!

@suyanhanx
Copy link
Member

image

May we reduce the sample counts of this test? Requesting COS seems to be too slow.

@xyjixyjixyji
Copy link
Contributor

xyjixyjixyji commented Jun 2, 2023

image

May we reduce the sample counts of this test? Requesting COS seems to be too slow.

I checked that each request takes about 250ms to return. Is this magnitude of latency unacceptable?

Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Copy link
Member Author

Xuanwo commented Jun 2, 2023

May we reduce the sample counts of this test? Requesting COS seems to be too slow.

Yes, fixed.

@Xuanwo
Copy link
Member Author

Xuanwo commented Jun 2, 2023

cos drop from 10m to 5m by replace with a bucket in us region.

@Xuanwo
Copy link
Member Author

Xuanwo commented Jun 2, 2023

cc @suyanhanx & @Ji-Xinyou to take another look.

Copy link
Contributor

@xyjixyjixyji xyjixyjixyji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Xuanwo Xuanwo merged commit 509b02c into main Jun 2, 2023
@Xuanwo Xuanwo deleted the refactor-nextest branch June 2, 2023 09:34
@Xuanwo Xuanwo mentioned this pull request Jun 2, 2023
@suyanhanx suyanhanx mentioned this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants