Fix memory leak

bindings/c/include/opendal.h

@@ -294,7 +294,7 @@ typedef struct opendal_result_read {
 } opendal_result_read;
 
 typedef struct opendal_reader {
-  struct BlockingReader *ptr;
+  struct BlockingReader *inner;
 } opendal_reader;
 
 /**
@@ -930,6 +930,8 @@ void opendal_list_entry_free(struct opendal_list_entry *ptr);
 
 intptr_t opendal_reader_read(const struct opendal_reader *self, uint8_t *buf, uintptr_t len);
 
+void opendal_reader_free(struct opendal_reader *ptr);
+
 #ifdef __cplusplus
 } // extern "C"
 #endif // __cplusplus

bindings/c/src/types.rs

@@ -412,13 +412,13 @@ impl opendal_list_entry {
 
 #[repr(C)]
 pub struct opendal_reader {
-    ptr: *mut od::BlockingReader,
+    inner: *mut od::BlockingReader,
 }
 
 impl opendal_reader {
     pub(crate) fn new(reader: od::BlockingReader) -> Self {
         Self {
-            ptr: Box::into_raw(Box::new(reader)),
+            inner: Box::into_raw(Box::new(reader)),
         }
     }
 
@@ -428,10 +428,18 @@ impl opendal_reader {
             panic!("The buffer given is pointing at NULL");
         }
         let buf = unsafe { std::slice::from_raw_parts_mut(buf, len) };
-        let r = (*self.ptr).read(buf);
+        let r = (*self.inner).read(buf);
         match r {
             Ok(n) => n as isize,
             Err(_) => -1,
         }
     }
+
+    #[no_mangle]
+    pub unsafe extern "C" fn opendal_reader_free(ptr: *mut opendal_reader) {
+        if !ptr.is_null() {
+            let _ = unsafe { Box::from_raw((*ptr).inner) };
+            let _ = unsafe { Box::from_raw(ptr) };
+        }
+    }
 }

bindings/c/tests/bdd.cpp

@@ -94,6 +94,7 @@ TEST_F(OpendalBddTest, FeatureTest)
     for (int i = 0; i < this->content.length(); i++) {
         EXPECT_EQ(this->content[i], buffer[i]);
     }
+    opendal_reader_free(reader.reader);
 
     // The blocking file should be deleted
     code = opendal_operator_blocking_delete(this->p, this->path.c_str());