NIFI-14052 Remove non-deterministic build properties #9558
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-14052 Removes non-deterministic build properties to address several findings from reviews of reproducible builds.
The Runtime Manifest generation process populates several build properties that are specific to the build environment, and none of these properties are used for the manifest itself. The following properties are removed:
Disabling episode file generation for code generated from XML Schema Definitions removes unused files that contain build timestamps.
Enabling the sortOutput property for Swagger OpenAPI specifications ensures deterministic output for YAML and JSON files that define the REST API.
For the
apache-release
profile, which is used for the release process, disabling the Build Number Maven Plugin and setting standard values forbuildBranch
,buildTag
, andbuildRevision
ensures that NARMANIFEST.MF
files contain standard values that reflect the release version.These changes together address the issues highlighted from the output of diffoscope for NiFi 2.0.0.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000
NIFI-00000
Pull Request Formatting
main
branchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-check
Licensing
LICENSE
andNOTICE
filesDocumentation