Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-14052 Remove non-deterministic build properties #9558

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

exceptionfactory
Copy link
Contributor

Summary

NIFI-14052 Removes non-deterministic build properties to address several findings from reviews of reproducible builds.

The Runtime Manifest generation process populates several build properties that are specific to the build environment, and none of these properties are used for the manifest itself. The following properties are removed:

  • Built-By
  • Maven-Home
  • Build-Java-Home
  • Build-Os-Version

Disabling episode file generation for code generated from XML Schema Definitions removes unused files that contain build timestamps.

Enabling the sortOutput property for Swagger OpenAPI specifications ensures deterministic output for YAML and JSON files that define the REST API.

For the apache-release profile, which is used for the release process, disabling the Build Number Maven Plugin and setting standard values for buildBranch, buildTag, and buildRevision ensures that NAR MANIFEST.MF files contain standard values that reflect the release version.

These changes together address the issues highlighted from the output of diffoscope for NiFi 2.0.0.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

- Removed Maven and Java Home properties from Runtime Manifest build
- Removed Built-By and Build-Os-Version properties from Runtime Manifest
- Disabled JAXB episode file generation
- Enabled output sorting for Swagger specification
@EndzeitBegins
Copy link
Contributor

EndzeitBegins commented Nov 30, 2024

Looks good. Appreciate the effort to make builds more consistent.

@EndzeitBegins EndzeitBegins merged commit de9042b into apache:main Nov 30, 2024
9 checks passed
@exceptionfactory
Copy link
Contributor Author

Thanks for reviewing and merging @EndzeitBegins!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants