Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-14041 - Improve MockPropertyValue and EL evaluation validation #9549

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

pvillard31
Copy link
Contributor

@pvillard31 pvillard31 commented Nov 22, 2024

Summary

NIFI-14041 - Improve MockPropertyValue and EL evaluation validation

While building a processor, I noticed that the test framework would throw an error if I'm in the below situation:

  • Processor with input forbidden
  • Property with EL support with Environment scope
  • Evaluation of the EL with .evaluateAttributeExpressions(Map<String,String>)

This should not throw an error. This PR is to fix this case as well as covering the overall EL evaluation in the test framework with proper unit testing.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this behavior @pvillard31. The changes look good, just noted some syntax improvement recommendations in the test class.

@pvillard31
Copy link
Contributor Author

Thanks for reviewing @exceptionfactory - pushed a commit to address your comments

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the adjustments @pvillard31! +1 merging

@exceptionfactory exceptionfactory merged commit cfa495b into apache:main Nov 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants