-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFI-13724 Add additional metadata to Registry events #9239
Conversation
Does anyone have some time to review the PR I submitted? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General idea seems good, just a few comments about handling optional fields, and a question about whether FLOW_VERSION
is really needed to be added.
...-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/event/EventFactory.java
Outdated
Show resolved
Hide resolved
...-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/event/EventFactory.java
Outdated
Show resolved
Hide resolved
...-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/event/EventFactory.java
Outdated
Show resolved
Hide resolved
...-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/event/EventFactory.java
Outdated
Show resolved
Hide resolved
...-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/event/EventFactory.java
Outdated
Show resolved
Hide resolved
...-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/event/EventFactory.java
Outdated
Show resolved
Hide resolved
...-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/event/EventFactory.java
Outdated
Show resolved
Hide resolved
...-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/event/EventFactory.java
Outdated
Show resolved
Hide resolved
Just pushed a new commit to fix a whitespace issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest updates look good, thanks for following up with the changes
Thanks @bbende! What would I need to do to have this PR also dropped onto the 1.x support branch. Ideally for the 1.28 release? |
@Dye357 At this point it mostly requires two separate PRs, one to |
Summary
NIFI-13724
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000
NIFI-00000
Pull Request Formatting
main
branchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-check
Licensing
LICENSE
andNOTICE
filesDocumentation