Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-13724 Add additional metadata to Registry events #9239

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

Dye357
Copy link
Contributor

@Dye357 Dye357 commented Sep 6, 2024

Summary

NIFI-13724

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • [ X] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • [ X] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • [X ] Pull Request based on current revision of the main branch
  • [X ] Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • [ X] Build completed using mvn clean install -P contrib-check
    • [ X] JDK 21

Licensing

  • [ n/a] New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • [ n/a] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • [ X] Documentation formatting appears as expected in rendered files

@exceptionfactory exceptionfactory changed the title nifi-13724 - added additional metadata to events NIFI-13724 Add additional metadata to Registry events Sep 6, 2024
@Dye357
Copy link
Contributor Author

Dye357 commented Sep 24, 2024

Does anyone have some time to review the PR I submitted?

Copy link
Contributor

@bbende bbende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General idea seems good, just a few comments about handling optional fields, and a question about whether FLOW_VERSION is really needed to be added.

@Dye357
Copy link
Contributor Author

Dye357 commented Oct 4, 2024

Just pushed a new commit to fix a whitespace issue.

Copy link
Contributor

@bbende bbende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest updates look good, thanks for following up with the changes

@bbende bbende merged commit 11ceb45 into apache:main Oct 21, 2024
5 checks passed
@Dye357
Copy link
Contributor Author

Dye357 commented Oct 21, 2024

Thanks @bbende! What would I need to do to have this PR also dropped onto the 1.x support branch. Ideally for the 1.28 release?

@bbende
Copy link
Contributor

bbende commented Oct 21, 2024

@Dye357 At this point it mostly requires two separate PRs, one to main and then one to support/nifi-1.x. For most NiFi specific changes, the cherry pick doesn't apply cleanly because everything has changed, but since this only registry, hopefully you can just create a local branch from support/nifi-1.x, cherry pick the commit, push the branch to your fork and create another PR against support/nifi-1.x.

Dye357 added a commit to Dye357/nifi that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants