NIFI-13119: When evaluating dependent Properties, the UI should identify when the Property value is a parameter reference and resolve the value accordingly #8724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcgilman
added
the
new ui
|
reviewing |
rfellows
reviewed
May 2, 2024
| if (dependentItem.descriptor.sensitive) { | ||
| return true; | ||
| } | ||
|
|
||
| // if the dependent item is visible, but does not require a specific | ||
| // dependent value consider the dependency met | ||
| if (this.nifiCommon.isEmpty(dependency.dependentValues)) { |
There was a problem hiding this comment.
We need to handle the scenario where the dependentItem.value is null so the dependency is not shown. An example of this is the AWSCredentialsProviderControllerService and the Assume Role ARN property. If it is unset, the other properties below it should not be shown (like Assume Role Session Name among others).
- When evaluating dependent Properties, the UI should identify when the Property value is a parameter reference and resolve the value accordingly.
- Requiring a value to be present when showing dependent property that doesn't require any specific value.
- Using error helper to get error string.
- Handle convert to parameter error scenario.
shubhluck
pushed a commit
to shubhluck/nifi
that referenced
this pull request
Jun 1, 2024
…ify when the Property value is a parameter reference and resolve the value accordingly (apache#8724) * NIFI-13119: - When evaluating dependent Properties, the UI should identify when the Property value is a parameter reference and resolve the value accordingly. * NIFI-13119: - Requiring a value to be present when showing dependent property that doesn't require any specific value. * NIFI-13119: - Using error helper to get error string. * NIFI-13119: - Handle convert to parameter error scenario. This closes apache#8724
shubhluck
pushed a commit
to shubhluck/nifi
that referenced
this pull request
Jun 1, 2024
…ify when the Property value is a parameter reference and resolve the value accordingly (apache#8724) * NIFI-13119: - When evaluating dependent Properties, the UI should identify when the Property value is a parameter reference and resolve the value accordingly. * NIFI-13119: - Requiring a value to be present when showing dependent property that doesn't require any specific value. * NIFI-13119: - Using error helper to get error string. * NIFI-13119: - Handle convert to parameter error scenario. This closes apache#8724
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NIFI-13119: