[NIFI-13093] use warn palette for all errors and introduce caution palette #8721
Conversation
scottyaslan
added
the
new ui
|
reviewing... |
...ndle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/themes/material.scss
Show resolved
Hide resolved
...k-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/styles/_app.scss
Show resolved
Hide resolved
...c/app/pages/bulletins/ui/bulletin-board/bulletin-board-list/bulletin-board-list.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Overall this looks great. I did find one thing that we might want to clean up but I'm also happy if we just want to log it and fix as part of another pull request...
Essentially, in dark mode, the checkbox we use to support select all, select none, or indicate some are selected isn't clearly defined when checked or indicating some are selected. It isn't immediately apparent that you can interact with it. It is fine when nothing is selected because it has an outline:
@scottyaslan let me know if you want to include a fix for this here or if we should log it separately.
Ooooooo good eye! Let's log it as a separate jira. Thanks! |
…lette (apache#8721) * [NIFI-13093] use warn palette for all errors and introduce caution palette * update semantic color names * update warn palette darker hue * import ErrorBanner component into cluster.component.spec.ts * .primary-contrast * some code clean up and reuse of .surface-contrast * caution color cleanup * update bulletin to use inverted contrast color and semantic caution-color class This closes apache#8721
…lette (apache#8721) * [NIFI-13093] use warn palette for all errors and introduce caution palette * update semantic color names * update warn palette darker hue * import ErrorBanner component into cluster.component.spec.ts * .primary-contrast * some code clean up and reuse of .surface-contrast * caution color cleanup * update bulletin to use inverted contrast color and semantic caution-color class This closes apache#8721
No description provided.