NIFI-6089 Add Parquet record reader and writer #3679
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NIFI-5755 Allow PutParquet processor to specify avro write configuration
SandishKumarHN
approved these changes
Aug 28, 2019
tpalfy
reviewed
Aug 29, 2019
...ord-utils/src/main/java/org/apache/nifi/record/listen/StandardSocketChannelRecordReader.java
Show resolved
Hide resolved
...quet-bundle/nifi-parquet-processors/src/main/java/org/apache/nifi/parquet/ParquetReader.java
Outdated
Show resolved
Hide resolved
...ifi-parquet-processors/src/main/java/org/apache/nifi/parquet/record/ParquetRecordReader.java
Outdated
Show resolved
Hide resolved
...bundle/nifi-parquet-processors/src/main/java/org/apache/nifi/parquet/utils/ParquetUtils.java
Outdated
Show resolved
Hide resolved
...parquet-processors/src/main/java/org/apache/nifi/parquet/stream/NifiSeekableInputStream.java
Outdated
Show resolved
Hide resolved
...parquet-processors/src/main/java/org/apache/nifi/parquet/stream/NifiSeekableInputStream.java
Show resolved
Hide resolved
...ifi-parquet-processors/src/test/java/org/apache/nifi/parquet/TestParquetRecordSetWriter.java
Show resolved
Hide resolved
|
Added new commit to address feedback. |
tpalfy
reviewed
Sep 2, 2019
There was a problem hiding this comment.
Overall looks good, just added some refactor suggestions.
I also did a manual test and seems to work well.
I used this template:
NIFI-6089_test.xml.zip
PutFile(f1ab37c0-016c-1000-75ed-2c5c42ea90c6) writes to: /tmp/NIFI-6089/out
That being said, this is quite a big change as it introduces the concept of inputLength and with that alters the RecordReaderFactory interface.
I tried to think of a solution that would make it possible to introduce this in a less invasive manner but I can't see a way around it.
Basically we can never know when we attach a record reader that requires this information.
As I see it, this feature indeed requires this large scale change.
...bundle/nifi-parquet-processors/src/main/java/org/apache/nifi/parquet/utils/ParquetUtils.java
Outdated
Show resolved
Hide resolved
...ifi-parquet-processors/src/test/java/org/apache/nifi/parquet/TestParquetRecordSetWriter.java
Outdated
Show resolved
Hide resolved
|
New commit for latest feedback |
|
Reviewing... |
MikeThomsen
approved these changes
Sep 4, 2019
VinceCastro
pushed a commit
to VinceCastro/nifi
that referenced
this pull request
Sep 5, 2019
NIFI-5755 Allow PutParquet processor to specify avro write configuration Review feedback Additional review feedback This closes apache#3679 Signed-off-by: Mike Thomsen <[email protected]>
szaboferee
pushed a commit
to szaboferee/nifi
that referenced
this pull request
Oct 7, 2019
NIFI-5755 Allow PutParquet processor to specify avro write configuration Review feedback Additional review feedback This closes apache#3679 Signed-off-by: Mike Thomsen <[email protected]>
patricker
pushed a commit
to patricker/nifi
that referenced
this pull request
Jan 22, 2020
NIFI-5755 Allow PutParquet processor to specify avro write configuration Review feedback Additional review feedback This closes apache#3679 Signed-off-by: Mike Thomsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NIFI-5755 Allow PutParquet processor to specify avro write configuration
This PR adds ParquetReader and ParquetRecordSetWriter, and also added some additional configuration to the PutParquet processor that was also needed in the record writer.
In order to implement the ParquetReader, the Parquet API requires knowledge of the inputLength ahead of time, which currently wasn't available to the RecordReaderFactory method that didn't have a FlowFile passed in.
To work around this I added an optional
long inputLengthparameter to that method and updated all the corresponding places in our code where it is called. The only place where we really don't know the input length is when reading from an unbound stream like ListenTCPRecord.