Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the website to the (upoming) jackpot30 20.0 #11

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jlahoda
Copy link
Contributor

@jlahoda jlahoda commented Jan 21, 2024

A variant of:
apache/netbeans-website#689
for this repository. Not sure which is the correct one, but this one was pointed out by @mbien

This adds (some) description of how to run the standard Java hints using Jackpot in Maven. This is a preliminary PR so far, as it depends on features added here:
apache/netbeans-jackpot30#36
and also on a release of Jackpot v version 20.0.

Copy link

@jtulach jtulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd expand the documentation to be more useful for a Jackpot outsider like me.

<artifactId>jackpot30-maven-plugin</artifactId>
<version>20.0</version>
<configuration>
<hint>SizeReplaceableByIsEmpty</hint>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a list of available values somewhere would be benefitial.

Having such list in a documentation would help people understand the value of Jackpot without trying it out manually.

Supported configuration options are:

- `hint`: the hint or hints that should be invoked. Can either be a comma-separated list of `@SuppressWarnings` keys of hints to invoke, or the display name of the hint to invoke,
- `configuration`: a configuration file (from NetBeans) specifying which hints should be run,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description how to obtain such configuration file is needed, otherwise it is not clear at all how to get it.


Supported goals are:

- `jackpot30:analyze`: run the hints, and print warnings produce by them possible failing the build, as specified,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `jackpot30:analyze`: run the hints, and print warnings produce by them possible failing the build, as specified,
- `jackpot30:analyze`: run the hints, and print warnings produce by them possibly failing the build, as specified,


- `jackpot30:analyze`: run the hints, and print warnings produce by them possible failing the build, as specified,
- `jackpot30:apply`: run the hints, and apply the primary proposed changes on each place where the hint would produce a warning. Please note this will be applied directly into the working copy of the files,
- `jackpot30:list`: list the support standard and custom Java hints.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give example how to check for @NotNull and co. annotations in a project?

@ebarboni
Copy link
Contributor

ebarboni commented Jan 22, 2024

@jlahoda this is the right place. Feel free to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants