Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

host test dataset for libsvmiter #9620

Merged
merged 1 commit into from
Jan 29, 2018
Merged

Conversation

szha
Copy link
Member

@szha szha commented Jan 29, 2018

Description

Fixes #9604

Checklist

Essentials

  • Passed code style checking (make lint)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Fix flaky test and re-enable

@szha szha requested a review from eric-haibin-lin January 29, 2018 19:55
Copy link
Member

@eric-haibin-lin eric-haibin-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you find any license restriction for this dataset?

@szha
Copy link
Member Author

szha commented Jan 29, 2018

I didn't find any restriction on redistributing the data, and it's already redistributed by many institutes.

@piiswrong piiswrong merged commit 16d995a into apache:master Jan 29, 2018
@szha szha deleted the svmiter_test branch January 29, 2018 23:03
@szha szha mentioned this pull request Jan 31, 2018
larroy pushed a commit to larroy/mxnet that referenced this pull request Jan 31, 2018
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_io.test_LibSVMIter fails intermittently
3 participants