-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Flake8 package checking python coding style: test_mkldnn.py, small tidy up #20406
Flake8 package checking python coding style: test_mkldnn.py, small tidy up #20406
Conversation
Hey @mozga-intel , Thanks for submitting the PR
CI supported jobs: [edge, unix-gpu, unix-cpu, clang, website, windows-gpu, miscellaneous, windows-cpu, sanity, centos-cpu, centos-gpu] Note: |
147e17c
to
2945898
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mxnet-bot run ci [unix-gpu] |
Jenkins CI successfully triggered : [unix-gpu] |
@mxnet-bot run ci [unix-gpu] |
Jenkins CI successfully triggered : [unix-gpu] |
@mxnet-bot run ci [unix-gpu] |
Jenkins CI successfully triggered : [unix-gpu] |
Description
This pull request tidies up the python unit-test file.
Confuguration
Flake8 package is required to get a result like please have a look: that: https://flake8.pycqa.org/en/latest/#. The main dir contains .flake8 file with a configuration, as follows: [Example]
Future consideration
This process should be added to a hook and it could be run before any commit (run lint). Additionally, CI should have a mechanism to detect differences between versions.
Checklist
Essentials
Changes
Comments