[NumPy] add op random.laplace #17316

AntiZpvoh · 2020-01-15T07:53:58Z

Description

Add op random.laplace, which could generate random samples with Laplace Distribution.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
Changes are complete (i.e. I finished coding on this PR)
All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Feature1, tests, (and when applicable, API doc)
Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

Signed-off-by: AntiZpvoh <[email protected]>

src/operator/numpy/random/np_laplace_op.cc

src/operator/numpy/random/np_laplace_op.cu

+
+NNVM_REGISTER_OP(_npi_laplace)
+.set_attr<FCompute>("FCompute<gpu>", NumpyLaplaceForward<gpu>);
+


Signed-off-by: AntiZpvoh <[email protected]>

python/mxnet/symbol/numpy/random.py

src/operator/numpy/random/np_laplace_op.h

Signed-off-by: AntiZpvoh <[email protected]>

xidulu

LGTM

…to NumPyLaplaceOp

…or-mxnet into np_laplace

haojin2

LGTM, @hzfan Can you double check on the ffi part?

…to NumPyLaplaceOp

…or-mxnet into NumPyLaplaceOp

src/api/operator/numpy/random/np_laplace_op.cc

src/operator/numpy/random/np_laplace_op.h

xidulu · 2020-03-13T14:38:28Z

LGTM regarding the logic.

* NumPy Laplace Distribution partly Frontend and Backend Signed-off-by: AntiZpvoh <[email protected]> * NumPy Laplace Distribution Backend style rectified Signed-off-by: AntiZpvoh <[email protected]> * NumPy Laplace Distribution Frontend modified Signed-off-by: AntiZpvoh <[email protected]> * Laplece op nightly test and normal op test correction Signed-off-by: AntiZpvoh <[email protected]> * NumPy Laplace Distribution unit test and code style Signed-off-by: AntiZpvoh <[email protected]> * Register uniform_n in CUDA Signed-off-by: AntiZpvoh <[email protected]> * Delete the registering of Laplace_n Signed-off-by: AntiZpvoh <[email protected]> * fix some alignment and indentation problems Signed-off-by: AntiZpvoh <[email protected]> * fix some sanity problems such as too long lines * fix some sanity problems again * laplace parmeters form change * implement basic laplace function * add frontend implement and ndarray loc case * complete the frontend * fix some sanity problems * fix some sanity problems * fix some typos * fix some problems * fix a typo * add size==() condition handling * fix some typos * remove unused code Co-authored-by: Ubuntu <[email protected]>

AntiZpvoh added 5 commits January 15, 2020 01:01

NumPy Laplace Distribution partly Frontend and Backend

585b238

Signed-off-by: AntiZpvoh <[email protected]>

NumPy Laplace Distribution Backend style rectified

2de8ac4

Signed-off-by: AntiZpvoh <[email protected]>

NumPy Laplace Distribution Frontend modified

b789cd7

Signed-off-by: AntiZpvoh <[email protected]>

Laplece op nightly test and normal op test correction

97a5d35

Signed-off-by: AntiZpvoh <[email protected]>

NumPy Laplace Distribution unit test and code style

94087e6

Signed-off-by: AntiZpvoh <[email protected]>

AntiZpvoh requested a review from szha as a code owner January 15, 2020 07:53

xidulu reviewed Jan 15, 2020

View reviewed changes

src/operator/numpy/random/np_laplace_op.cc Outdated Show resolved Hide resolved

xidulu reviewed Jan 15, 2020

View reviewed changes

src/operator/numpy/random/np_laplace_op.cu

NNVM_REGISTER_OP(_npi_laplace)

.set_attr<FCompute>("FCompute<gpu>", NumpyLaplaceForward<gpu>);

This comment was marked as resolved.

Sign in to view

AntiZpvoh added 2 commits January 15, 2020 16:11

Register uniform_n in CUDA

eec4ec2

Signed-off-by: AntiZpvoh <[email protected]>

Delete the registering of Laplace_n

14dd8b2

Signed-off-by: AntiZpvoh <[email protected]>

haojin2 self-assigned this Jan 15, 2020

haojin2 added the Numpy label Jan 15, 2020