This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
added large tensor support for add_n and tests for more ops #16476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
access2rohit
changed the title
ChaiBapchya
reviewed
Oct 16, 2019
ChaiBapchya
reviewed
Oct 16, 2019
ChaiBapchya
approved these changes
Oct 16, 2019
|
@sxjscience @apeforest @anirudh2290 @zheng-da @pengzhao-intel This PR is ready for review |
anirudh2290
reviewed
Oct 17, 2019
anirudh2290
reviewed
Oct 17, 2019
| assert z[-1] == 2 | ||
| z = nd.minimum(x, 5) | ||
| assert z[0] == 3 | ||
| assert z[-1] == 3 |
There was a problem hiding this comment.
are the backward pass of any of these functions tested.
There was a problem hiding this comment.
Only forward passes are required by DGL. So only forward passes are tested.
There was a problem hiding this comment.
is there some large tensor docs in mxnet website. That should explicitly call out that the backward pass has not been verified with large tensor.
There was a problem hiding this comment.
I have to write that. Currently we don't have any docs explaining how to use large tensor support and caveats along with limitations and perf regressions.
access2rohit
force-pushed
the
final_dgl_ops
branch
from
014a137 to
1917af8
Compare
|
@anirudh2290 good to merge? |
access2rohit
force-pushed
the
final_dgl_ops
branch
from
1917af8 to
da721d8
Compare
anirudh2290
approved these changes
Oct 17, 2019
|
@mxnet-label-bot add [pr-awaiting-merge] |
access2rohit
force-pushed
the
final_dgl_ops
branch
from
da721d8 to
c6ac555
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added large tensor support for add_n and tests for:
load()
save()
add_n()
modulo()
maximum()
minimum()
Checklist
Essentials
Testing
Will run full suite of tests and paste here.