This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Dgl ops 2 #16416
Merged
Dgl ops 2 #16416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larroy
approved these changes
Oct 9, 2019
|
Okay, this is specific to large array. |
|
Batch_dot operator hasn't been tested for large array before. Atleast not in the test_large_array.py file |
access2rohit
approved these changes
Oct 16, 2019
anirudh2290
reviewed
Oct 17, 2019
There was a problem hiding this comment.
The code for the current PR and https://github.com/apache/incubator-mxnet/pull/16497/files looks very similar. What is the reason for two different PRs ?
access2rohit
approved these changes
Oct 18, 2019
|
@anirudh2290 It looks same coz we are testing same functions. Agreed that we can bring both (large array input dim >=2) and large vector under same file. But for now going with this. Adding "merging array & vector tests" to the todo. |
|
@ChaiBapchya can you restart sanity test on your PR |
anirudh2290
reviewed
Oct 21, 2019
anirudh2290
reviewed
Oct 21, 2019
anirudh2290
approved these changes
Oct 21, 2019
ChaiBapchya
force-pushed
the
dgl_ops_2
branch
from
3731ee1 to
ad6239b
Compare
ChaiBapchya
force-pushed
the
dgl_ops_2
branch
from
ad6239b to
10376f8
Compare
anirudhacharya
approved these changes
Oct 23, 2019
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added tests for following ops (required by DGL)
Input - Large tensor array
Hyperbolic ops
Misc
Logical Ops
Regression
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes