Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add list_ctx to ParameterDict #16185

Merged
merged 2 commits into from
Sep 25, 2019
Merged

Conversation

Kh4L
Copy link
Contributor

@Kh4L Kh4L commented Sep 17, 2019

Description

Add the list_ctx method to gluon's ParamDict to get all the contexts used by the underlying parameters.

Checklist

Essentials

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Add list_ctx to ParameterDict, tests, (and when applicable, API doc)
  • Test for ParameterDict reset_ctx, tests, (and when applicable, API doc)

@Kh4L Kh4L requested a review from szha as a code owner September 17, 2019 11:03
@Kh4L Kh4L force-pushed the parameterdict_list_ctx branch from 0f76ef5 to abc5b91 Compare September 17, 2019 14:10
@Kh4L Kh4L force-pushed the parameterdict_list_ctx branch from 9b74efc to 17051dd Compare September 17, 2019 22:59
@Kh4L Kh4L force-pushed the parameterdict_list_ctx branch from 17051dd to 4b817e2 Compare September 25, 2019 16:11
@ptrendx ptrendx merged commit df34e76 into apache:master Sep 25, 2019
drivanov pushed a commit to drivanov/incubator-mxnet that referenced this pull request Sep 26, 2019
* Add list_ctx to ParameterDict

Signed-off-by: Serge Panev <[email protected]>

* Add assert to test reset_ctx

Signed-off-by: Serge Panev <[email protected]>
larroy pushed a commit to larroy/mxnet that referenced this pull request Sep 28, 2019
* Add list_ctx to ParameterDict

Signed-off-by: Serge Panev <[email protected]>

* Add assert to test reset_ctx

Signed-off-by: Serge Panev <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants