Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] Numpy behavior normal distribution #16109

Merged
merged 9 commits into from
Sep 19, 2019

Conversation

xidulu
Copy link
Contributor

@xidulu xidulu commented Sep 6, 2019

Description

As title

@stu1130 I implemented a unified `_copy' function in dist_common.h

https://github.com/apache/incubator-mxnet/pull/16109/files#diff-756e5043564af2ba47c700240749b31dR45

which could be used to copy an indicator variable from device to host, you could probably make use of it in multinomial.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@xidulu xidulu requested a review from szha as a code owner September 6, 2019 06:12
@reminisce reminisce added the Numpy label Sep 6, 2019
@stu1130
Copy link
Contributor

stu1130 commented Sep 18, 2019

@xidulu thanks i’ll take a look

@stu1130 stu1130 mentioned this pull request Sep 18, 2019
7 tasks
Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haojin2 haojin2 merged commit 66c4207 into apache:master Sep 19, 2019
larroy pushed a commit to larroy/mxnet that referenced this pull request Sep 28, 2019
* normal implemented

* numpy behavior normal imlemented

* retrigger CI

* retrigger CI

* regrigger ci

* add normal parameter check

* add raise for normal

* remove dead code
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants