This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Check expected vs. actual Node inputs. Many operators non-compliant. #15834
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #15688 fixed, among other things, a discrepancy between the number of inputs specified in the _backward_clip operator definition via .set_num_inputs() and the number of inputs actually created for the backward node (1 vs 2, respectively). Use of monitors (for debugging) requires these input counts to be equal.
This PR supplies the check of expected vs. actual node input counts and exposes the fact that many operators have a discrepancy. As suggested by @ptrendx, this check is best supplied in this separate PR, as it might take some time to fix all the non-compliant operators. The first commit only supplies the check, not operator fixes, and so is expected to fail.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments