Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

update previous flaky naive engine test #15651

Merged
merged 22 commits into from
Jul 30, 2019
Merged

update previous flaky naive engine test #15651

merged 22 commits into from
Jul 30, 2019

Conversation

Zha0q1
Copy link
Contributor

@Zha0q1 Zha0q1 commented Jul 24, 2019 •
edited
Loading

Description

update flaky test reported in #15414
fixes #15414

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@abhinavs95
Copy link
Contributor

@mxnet-label-bot add [Flaky, test]

@Zha0q1 Zha0q1 changed the title [WIP] update previous flaky naive engine test update previous flaky naive engine test Jul 25, 2019
apeforest
apeforest reviewed Jul 26, 2019
View reviewed changes
tests/python/unittest/test_profiler.py Outdated
@@ -275,6 +275,8 @@ def test_aggregate_duplication():
file_name = 'test_aggregate_duplication.json'
enable_profiler(profile_filename = file_name, run=True, continuous_dump=True, \
aggregate_stats=True)
# clear aggregate stats
profiler.dumps(reset = True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove space around '='.
FYI: http://google.github.io/styleguide/pyguide.html#36-whitespace

apeforest
apeforest reviewed Jul 26, 2019
View reviewed changes
tests/python/unittest/test_profiler.py Outdated
@@ -332,6 +334,8 @@ def create_operator(self, ctx, in_shapes, in_dtypes):
file_name = 'test_custom_operator_profiling.json'
enable_profiler(profile_filename = file_name, run=True, continuous_dump=True,\
aggregate_stats=True)
# clear aggregate stats
profiler.dumps(reset = True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove space around '='.
FYI: http://google.github.io/styleguide/pyguide.html#36-whitespace

apeforest
apeforest reviewed Jul 26, 2019
View reviewed changes
tests/python/unittest/test_profiler.py Outdated
enable_profiler(profile_filename = file_name, run=True, continuous_dump=True,\
aggregate_stats=True)
# clear aggregate stats
profiler.dumps(reset = True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove space around '='.
FYI: http://google.github.io/styleguide/pyguide.html#36-whitespace

apeforest
apeforest approved these changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@apeforest apeforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a nit comment. Otherwise LGTM. thanks!

@Zha0q1 Zha0q1 changed the title update previous flaky naive engine test [WIP] update previous flaky naive engine test Jul 26, 2019
@Zha0q1
Copy link
Contributor Author

Zha0q1 commented Jul 29, 2019

@apeforest Can you help me merge? Thanks!

@Zha0q1 Zha0q1 changed the title [WIP] update previous flaky naive engine test update previous flaky naive engine test Jul 29, 2019
ChaiBapchya
ChaiBapchya approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Add "fixes #issue_number" to description
So that once its merged, issue gets auto closed.

tests/python/unittest/test_profiler.py
target_dict = json.loads(debug_str)
assert 'Time' in target_dict and 'Custom Operator' in target_dict['Time'] \
and 'MySigmoid::pure_python' in target_dict['Time']['Custom Operator'] \
and '_backward_MySigmoid::pure_python' in target_dict['Time']['Custom Operator'] \
and 'MySigmoid::_zeros' in target_dict['Time']['Custom Operator']
profiler.set_state('stop')

def test_custom_operator_profiling_multiple_custom_ops_imperative(seed = None, \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was function name changed from test_ to check_?
Gotcha

@Zha0q1
Copy link
Contributor Author

Zha0q1 commented Jul 29, 2019

LGTM! Add "fixes #issue_number" to description
So that once its merged, issue gets auto closed.

Added! Thanks!

@Zha0q1
Copy link
Contributor Author

Zha0q1 commented Jul 29, 2019

LGTM! Add "fixes #issue_number" to description
So that once its merged, issue gets auto closed.

Added! Thanks!

Oh adding that started another round of testing😂

@Zha0q1 Zha0q1 changed the title update previous flaky naive engine test [WIP]update previous flaky naive engine test Jul 30, 2019
@Zha0q1 Zha0q1 changed the title [WIP]update previous flaky naive engine test update previous flaky naive engine test Jul 30, 2019
@apeforest apeforest merged commit f0b6d72 into apache:master Jul 30, 2019
anirudhacharya pushed a commit to anirudhacharya/mxnet that referenced this pull request Aug 20, 2019
@Zha0q1
update previous flaky naive engine test (apache#15651)
f755b5a 
* update precious flaky naive engine test

* retriever tests

* retrigger tests

* retrigger tests

* retrigger tests

* retrigger tests

* retrigger tests

* Update test_profiler.py

* retrigger tests

* retrigger tests

* retrigger tests

* retrigger tests

* retrigger tests

* retrigger tests

* Update test_profiler.py

* retrigger tests

* retrigger tests

* retrigger tests

* retrigger tests

* Update test_profiler.py

* retrigger tests

* Update test_profiler.py
access2rohit pushed a commit to access2rohit/incubator-mxnet that referenced this pull request Sep 6, 2019
Revert "update previous flaky naive engine test (apache#15651)"
f0f8051 
This reverts commit f0b6d72.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ChaiBapchya ChaiBapchya ChaiBapchya approved these changes

@apeforest apeforest apeforest approved these changes

Assignees
No one assigned
Labels
Flaky Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky test_profiler.test_custom_operator_profiling_naive_engine
5 participants
@Zha0q1 @abhinavs95 @apeforest @ChaiBapchya @marcoabreu