Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

update profiler tutorial #15580

Merged
merged 9 commits into from
Jul 26, 2019
Merged

update profiler tutorial #15580

merged 9 commits into from
Jul 26, 2019

Conversation

Zha0q1
Copy link
Contributor

@Zha0q1 Zha0q1 commented Jul 17, 2019 •
edited
Loading

Description

fix nightly test failure and add a new section explaining some implicit api usage rules

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@Zha0q1 Zha0q1 requested a review from szha as a code owner July 17, 2019 23:25
@Zha0q1 Zha0q1 closed this Jul 18, 2019
@Zha0q1 Zha0q1 reopened this Jul 18, 2019
ChaiBapchya
ChaiBapchya approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with minor changes

docs/tutorials/python/profiler.md Outdated Show resolved Hide resolved
docs/tutorials/python/profiler.md Show resolved Hide resolved
docs/tutorials/python/profiler.md Show resolved Hide resolved
@Zha0q1 Zha0q1 closed this Jul 19, 2019
@Zha0q1 Zha0q1 reopened this Jul 19, 2019
@karan6181
Copy link
Contributor

@mxnet-label-bot add [Doc, pr-awaiting-review]

@marcoabreu marcoabreu added Doc pr-awaiting-review PR is waiting for code review labels Jul 19, 2019
@Zha0q1 Zha0q1 closed this Jul 19, 2019
@Zha0q1 Zha0q1 reopened this Jul 19, 2019
sandeep-krishnamurthy
sandeep-krishnamurthy suggested changes Jul 20, 2019
View reviewed changes
Copy link
Contributor

@sandeep-krishnamurthy sandeep-krishnamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Few comments.

docs/tutorials/python/profiler.md Show resolved Hide resolved
docs/tutorials/python/profiler.md Show resolved Hide resolved
docs/tutorials/python/profiler.md Show resolved Hide resolved
docs/tutorials/python/profiler.md Show resolved Hide resolved
@Zha0q1
Copy link
Contributor Author

Zha0q1 commented Jul 24, 2019

@sandeep-krishnamurthy Could you help me take a look again? Thanks!

@sandeep-krishnamurthy
Copy link
Contributor

@IvyBazan - Can you please give a review for this tutorial? Thank you.

@IvyBazan
Copy link
Contributor

LGTM!

apeforest
apeforest reviewed Jul 26, 2019
View reviewed changes
docs/tutorials/python/profiler.md Outdated
@@ -244,15 +239,17 @@ class CustomAddOneProp(mx.operator.CustomOpProp):

inp = mx.nd.zeros(shape=(500, 500))

profiler.set_config(profile_all=True, continuous_dump = True)
profiler.set_config(profile_all=True, continuous_dump=True, \
aggregate_stats=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: indentation not aligned.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

apeforest
apeforest approved these changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@apeforest apeforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apeforest apeforest merged commit c310763 into apache:master Jul 26, 2019
anirudhacharya pushed a commit to anirudhacharya/mxnet that referenced this pull request Aug 20, 2019
@Zha0q1
update profiler tutorial (apache#15580)
63639e3 
* update profiler tutorial

* Update profiler.md

* Update profiler.md

* Update profiler.md

* Re-Trigger build

* Re-Trigger build

* Re-Trigger build

* Update profiler.md
access2rohit pushed a commit to access2rohit/incubator-mxnet that referenced this pull request Sep 6, 2019
Revert "update profiler tutorial (apache#15580)"
3583c55 
This reverts commit c310763.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ChaiBapchya ChaiBapchya ChaiBapchya approved these changes

@apeforest apeforest apeforest approved these changes

@sandeep-krishnamurthy sandeep-krishnamurthy sandeep-krishnamurthy approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
Doc pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Zha0q1 @karan6181 @sandeep-krishnamurthy @IvyBazan @apeforest @ChaiBapchya @marcoabreu