This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is PR is work in progress and is raised to get the API definition reviewed. |
7 tasks
@mxnet-label-bot add [KVStore, C API, pr-work-in-progress] |
e53c5cc
to
3507312
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you remove ignore_sparse from the interface, and add unit tests? Otherwise looks good.
@anandj91 gentle ping to address the comments, thanks! |
c1ceca4
to
2eb6321
Compare
@anandj91 thanks for the awesome contribution! |
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Sep 28, 2019
* Switch to latest ps-lite * Add PushPull API * Add PushPull test cases
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new KVStore API called
pushpull
.pushpull
is a coalesced version ofpush
andpull
APIs.pushpull
however can send and receive the key-value pairs with just one network call to the KVServer, thus eliminating the need to send a separatepull
.Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments