Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Opperf] Add optimizer update operator benchmarks to opperf #15522

Merged
merged 12 commits into from
Jul 28, 2019

Conversation

ChaiBapchya
Copy link
Contributor

@ChaiBapchya ChaiBapchya commented Jul 12, 2019

Description

Added neural network optimizer (Adam, sgd, etc) update operators to the existing set of opperf benchmarks

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Code is well-documented:
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Added optimizer update ops to opperf

@sandeep-krishnamurthy @apeforest

@ChaiBapchya ChaiBapchya changed the title Add optimizer update operator benchmarks to opperf [Opperf] Add optimizer update operator benchmarks to opperf Jul 12, 2019
@ChaiBapchya
Copy link
Contributor Author

@mxnet-label-bot add [Benchmark, Operator]

@sandeep-krishnamurthy
Copy link
Contributor

Thanks for the contribution. I don't see params such as grad, momentum etc. in this PR, how are you creating those parameters for these optimizers benchmarks?

Copy link
Contributor

@sandeep-krishnamurthy sandeep-krishnamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM. Thank you.
Did you run opperf end to end on CPU and GPU after this change?
(Reason: Earlier, when adding new parameters for new operator coverage, I had faced conflicts in some other ops because of same param name).
Thanks.

@sandeep-krishnamurthy
Copy link
Contributor

@ChaiBapchya - Can you take a look at CI failures?

@ChaiBapchya
Copy link
Contributor Author

@sandeep-krishnamurthy Yup, good to review. Thanks.

@sandeep-krishnamurthy sandeep-krishnamurthy merged commit 3d366a3 into apache:master Jul 28, 2019
@ChaiBapchya ChaiBapchya deleted the opperf_optimizer branch July 28, 2019 05:52
anirudhacharya pushed a commit to anirudhacharya/mxnet that referenced this pull request Aug 20, 2019
…5522)

* optimizer for opperf benchmark

* Trigger notification

* missed function call

* added params

* minor typos

* Trigger notification

* resolve default params

* temp remove multi op

* take care of apache#15643

* numbering typo
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants