Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

ImageDetIter: fix property not updating bug #13085

Merged
merged 1 commit into from
Nov 29, 2018

Conversation

zhreshold
Copy link
Member

Description

Fix a minor property bug that label_shape is not properly updated during reshape.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@zhreshold zhreshold requested a review from szha as a code owner November 2, 2018 00:31
@ankkhedia
Copy link
Contributor

@zhreshold Thanks for your contribution!
Request you to look into CI failures

@mxnet-label-bot[pr-awaiting-review, python, test]

@marcoabreu marcoabreu added pr-awaiting-review PR is waiting for code review Python Test labels Nov 2, 2018
Copy link
Contributor

@kalyc kalyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stu1130
Copy link
Contributor

stu1130 commented Nov 21, 2018

@szha could you take a look at it?

Copy link
Contributor

@vandanavk vandanavk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vandanavk
Copy link
Contributor

@mxnet-label-bot update [Python, Test, pr-awaiting-merge]

@marcoabreu marcoabreu added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-review PR is waiting for code review labels Nov 27, 2018
Copy link
Contributor

@sandeep-krishnamurthy sandeep-krishnamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data_shape is not set in the init(), should we set it?

@zhreshold
Copy link
Member Author

@sandeep-krishnamurthy data_shape set in super class.

@zhreshold zhreshold merged commit e434251 into apache:master Nov 29, 2018
@zhreshold zhreshold deleted the fix-image-det-iter branch November 29, 2018 21:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge Python Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants