Make the proxy jump resolver a bit more flexible. #477
Conversation
| do { | ||
| entry = resolveHost(userInfo, host, port, context, null); | ||
| jumps.add(entry); | ||
| } while((host = entry.getProxyJump()) != null); |
There was a problem hiding this comment.
The list may also need to be reversed. Both your configurations should give a connection
client -> jump3 -> jump2 -> jump1 -> target
but I think they give
client -> jump1 -> jump2 -> jump3 -> target
?
Also: what if host at line 690 is again a chain (multiple hosts separated by commas)? As in the config
Host jump1
Hostname jump1.corp
Port 22
User nightman
ProxyJump jump2,jump3
LogLevel QUIET
Host jump2
HostName jump2.dmz.corp
Port 22
User nightman
#ProxyJump jump3
LogLevel QUIET
Host jump3
HostName jump3.dmz.corp
Port 22
User nightman
LogLevel QUIET
Host host*.dmz.corp
ProxyJump jump1
|
|
Thank you; looks much better. Not sure about the precedence of the lists but we can tackle that issue when it arises. Could you add tests for this? |
|
Sorry, I do not have the time at the moment getting familiar with your test suite etc. |
|
Fixed differently via PR #512 (including tests). |
|
In what release the changes will be included? I can't find this information... |
|
See https://github.com/apache/mina-sshd/blob/master/docs/changes/2.13.0.md. It does mention the issue. (Use 2.13.1. Publishing to Maven Central of 2.13.0 omitted the source bundles.) |
fix #318.