[MNG-7644] Fix version comparison ( .X1 < -X2 for any string qualifier x ), 3.8.x branch

[sultan]

The current version parser does not treat .RC and -RC correctly:
actual : 1.0.0.RC1 > 1.0.0-RC2
expected : 1.0.0.RC1 < 1.0.0-RC2
 
because RC1 < RC2
how to fix : place a list item before qualifier

as a consequence for any string qualifier x:
previously:

• 1.0.0.X1 > 1.0.0-X2
• 1.0.X < 1.0.0.X

now:

• 1.0.0.X1 < 1.0.0-X2
• 1.0.X == 1-X == 1.0.0.X

---

Following this checklist to help us incorporate your
contribution quickly and easily:

• Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without
  pulling in other changes.
• Each commit in the pull request should have a meaningful subject line and body.
• Format the pull request title like [MNG-XXX] SUMMARY,
  where you replace MNG-XXX and SUMMARY with the appropriate JIRA issue.
• Also format the first line of the commit message like [MNG-XXX] SUMMARY.
  Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean verify to make sure basic checks pass. A more thorough check will
  be performed on your pull request automatically.
• You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

• In any other case, please file an Apache Individual Contributor License Agreement.

[michael-o]

Does this really only apply to RC or anything else which has the pattern dot/hyphen{item}{digit/number}?

[sultan]

Does this really only apply to RC or anything else which has the pattern dot/hyphen{item}{digit/number}?

it is intended to apply to all string qualifiers: dot/hyphen{string item}

[michael-o]

Does this really only apply to RC or anything else which has the pattern dot/hyphen{item}{digit/number}?

it is intended to apply to all string qualifiers: dot/hyphen{string item}

Then please generalize the issue summary as well as the description and add more tests which depict that is general and not specific. Let's make this complete for master first and then I consent, then you can back port and save time.

[sultan]

Does this really only apply to RC or anything else which has the pattern dot/hyphen{item}{digit/number}?

it is intended to apply to all string qualifiers: dot/hyphen{string item}

Then please generalize the issue summary as well as the description and add more tests which depict that is general and not specific. Let's make this complete for master first and then I consent, then you can back port and save time.

it's fair @michael-o, i updated the Jira and PRs/commits.
i hope its all ok now.
thank you very much for your time!

[michael-o]

This needs to be generalized as well.

[sultan]

yes

[sultan]

done

[michael-o]

Merged.

[sultan]

@michael-o we may want to consider this a major change and reverting this one

[michael-o]

@michael-o we may want to consider this a major change and reverting this one

Then docs need to be reverted as well, no?

[sultan]

@michael-o we may want to consider this a major change and reverting this one

Then docs need to be reverted as well, no?

the docs may need an update to explain how 3.x and 4.x treats the versions order differently

[michael-o]

@michael-o we may want to consider this a major change and reverting this one

Then docs need to be reverted as well, no?

the docs may need an update to explain how 3.x and 4.x treats the versions order differently

Let's do the following: Keep the change with RC1/RC2 even 3.8.x with the docs in place and see whether there will be reports due to the change in behavior. If really someone complains I'd be willing to fix this regression and release 3.8.8 for this. Otherwise this edge case fix makes life much easier for others.

[sultan]

@michael-o we may want to consider this a major change and reverting this one

Then docs need to be reverted as well, no?

the docs may need an update to explain how 3.x and 4.x treats the versions order differently

Let's do the following: Keep the change with RC1/RC2 even 3.8.x with the docs in place and see whether will be reports due to the change in behavior. If really someone complains I'd be willing to fix this regression and release 3.8.8 for this. Otherwise this edge case fix makes life much easier for others.

Nice! thanks Michael