[master][MNG-7156][MNG-7285] Add locking in MojoExecutor #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
reviewed
Dec 2, 2021
maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoExecutor.java
Outdated
Show resolved
Hide resolved
michael-o
reviewed
Dec 2, 2021
| @@ -202,6 +210,80 @@ private void execute( MavenSession session, MojoExecution mojoExecution, Project | |||
| } | |||
| } | |||
|
|
|||
| try ( ProjectLock lock = new ProjectLock( session, mojoDescriptor, aggregatorLock ) ) | |||
There was a problem hiding this comment.
This totally looks like SyncContext in Resolver. @cstamas
There was a problem hiding this comment.
Yes, I think leveraging the AutoCloseable makes sense here, but it's just a syntactic trick to avoid the finally block...
There was a problem hiding this comment.
A real example when things "click" into their place...
michael-o
reviewed
Dec 2, 2021
maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoExecutor.java
Show resolved
Hide resolved
cstamas
approved these changes
Dec 2, 2021
This was referenced Dec 3, 2021
gnodet
changed the title
michael-o
requested changes
Dec 17, 2021
maven-core/src/test/java/org/apache/maven/project/ProjectBuilderTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MNG-7156
https://issues.apache.org/jira/browse/MNG-7285
Hopefully supersedes #476, #578, #625 in order to fix the threading problems in
MavenProjectduring parallel builds.This may need to be combined with #570 and apache/maven-integration-testing#127