[MNG-5222] - Maven 3 no longer logs warnings about deprecated parameter in plugin #285

belingueres · 2019-09-09T03:38:56Z

parameters

Added warning when setting deprecated parameter with value different
than the default.
Stop using deprecated DebugConfigurationListener class.

Following this checklist to help us incorporate your
contribution quickly and easily:

Make sure there is a JIRA issue filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
Each commit in the pull request should have a meaningful subject line and body.
Format the pull request title like [MNG-XXX] - Fixes bug in ApproximateQuantiles,
where you replace MNG-XXX with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Run mvn clean verify to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.

slachiewicz · 2020-01-01T22:43:12Z

Do you have any example of a plugin where you can check the effect of this change?

belingueres · 2020-01-02T02:36:55Z

m-compiler-p has some deprecated parameters.

slachiewicz · 2020-01-02T09:25:46Z

ok, looks good to me.

[INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ maven-model ---
[WARNING]   Parameter 'optimize' (User Parameter 'maven.compiler.optimize') is deprecated. This property is a no-op in {@code javac}.

rfscholte · 2020-01-02T10:39:39Z

maven-core/src/main/java/org/apache/maven/plugin/internal/ValidatingConfigurationListener.java

+                if ( parameter.getExpression() != null )
+                {
+                    String userParam = parameter.getExpression().replace( "${", "'" ).replace( '}', '\'' );
+                    sb.append( " (User Parameter " ).append( userParam ).append( ")" );


It is called User Property, not User Parameter.
Also be aware that the difference between expression and default-value wasn't that clear in the past, so there are still plugins around with odd values. So only show it in case of a valid expression.

Do you have and example of such an old plugin? How do I know if it is a "valid expression" at this stage of the plugin execution?

maven-core/src/main/java/org/apache/maven/plugin/internal/ValidatingConfigurationListener.java

hboutemy · 2020-04-22T07:19:04Z

while working on MNG-5001 (failure on read-only parameters), I imagine I'll work on this one also

question: do you have an example of deprecated parameter on a plugin available in the wild (ideally Maven 2 compatible) so we can easily test behaviour with misc Maven versions, please?

belingueres · 2020-04-22T12:17:13Z

@hboutemy please see maven-compiler-plugin. It has deprecated compilerArguments and optimize properties.

michael-o · 2021-09-19T17:46:16Z

Is there still interest in this for Maven 4?

slawekjaranowski · 2022-03-14T09:53:42Z

I hope it is interested also for 3.x
Change not seems too complicated and can be finished / refreshed and merged.

slawekjaranowski · 2022-03-14T09:53:42Z

I hope it is interested also for 3.x
Change not seems too complicated and can be finished / refreshed and merged.

slawekjaranowski · 2022-03-15T22:37:07Z

@belingueres Thanks for your contributions.
I will try to process forward this change.

First I kindly ask you to rebase with current code base - we will see if build pass.

belingueres · 2022-03-16T04:41:21Z

@slawekjaranowski Rebased and changed logger for SLF4J.
Built maven-core ok.
Ran core-its with one single failure on mng-4913 (I don't know if its related to this change)

slawekjaranowski

Responsibility of ValidatingConfigurationListener is to check configurations - so I don't mix it ...

Proposition
create class: CompositeConfigurationListener implements ConfigurationListener

with constructor (List<ConfigurationListener> listeners )
in implementation we call each listener

We can leave DebugConfigurationListener for show debug values
and create next DeprecatedConfigurationListener with logging about deprecated params

maven-core/src/main/java/org/apache/maven/plugin/internal/ValidatingConfigurationListener.java

slawekjaranowski

I consulted with other and reviewed again, there are not many lines of code here, so in this simple case is acceptable to put in one class.

Class DebugConfigurationListener can be removed.

Pleas look at rest of my comments.

maven-core/src/main/java/org/apache/maven/plugin/internal/ValidatingConfigurationListener.java

slawekjaranowski · 2022-03-26T10:09:46Z

Summarize current discussion:

please delegate to DebugConfigurationListener
please use logger = LoggerFactory.getLogger(...) in ValidatingConfigurationListener
protect warnDeprecated by loger.isWarnEnabled
call warnDeprecated from notify method

and will be ok for me

slawekjaranowski · 2022-03-27T09:29:29Z

@belingueres thanks - please squash to one commit it will be easier for cherry pick
@slachiewicz I see that you created branch MNG-5222, do you want to finish it? If no I take care about it.

slachiewicz · 2022-03-27T09:39:28Z

Feel free to drop my branch - that was just quick rebase of original pr.

parameters - Added warning when setting deprecated parameter with value different than the default. - Changed Logger to SLF4J.

slawekjaranowski · 2022-04-01T22:26:58Z

Branch for change created with simple fix after IT tests - #705
and IT tests - apache/maven-integration-testing#143

slawekjaranowski · 2022-04-01T22:32:10Z

@belingueres Thanks for contributing - your commit and credential will be preserved in my PR, this one can be closed.

slachiewicz approved these changes Jan 2, 2020

View reviewed changes

rfscholte reviewed Jan 2, 2020

View reviewed changes

maven-core/src/main/java/org/apache/maven/plugin/internal/ValidatingConfigurationListener.java Outdated Show resolved Hide resolved

belingueres force-pushed the MNG-5222 branch from 2a25e06 to aa3b84d Compare April 22, 2020 21:08

slachiewicz changed the title ~~[MNG-5222] - Maven 3 no longer logs warnings about deprecated plugin~~ [MNG-5222] - Maven 3 no longer logs warnings about deprecated parameter in plugin Oct 10, 2021

belingueres force-pushed the MNG-5222 branch 2 times, most recently from c9f8dd7 to cd3beee Compare March 16, 2022 04:37

slawekjaranowski requested changes Mar 16, 2022

View reviewed changes

slawekjaranowski requested changes Mar 17, 2022

View reviewed changes

slawekjaranowski mentioned this pull request Mar 18, 2022

[discussion] synchronization of code copied from Maven core apache/maven-mvnd#609

Open

[MNG-5222] - Maven 3 no longer logs warnings about deprecated plugin

b3b8176

parameters - Added warning when setting deprecated parameter with value different than the default. - Changed Logger to SLF4J.

belingueres force-pushed the MNG-5222 branch from 24acb4d to b3b8176 Compare March 27, 2022 14:12

slawekjaranowski self-assigned this Mar 31, 2022

slawekjaranowski closed this Apr 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MNG-5222] - Maven 3 no longer logs warnings about deprecated parameter in plugin #285

[MNG-5222] - Maven 3 no longer logs warnings about deprecated parameter in plugin #285

belingueres commented Sep 9, 2019

slachiewicz commented Jan 1, 2020

belingueres commented Jan 2, 2020

slachiewicz commented Jan 2, 2020

rfscholte Jan 2, 2020

belingueres Jan 7, 2020

hboutemy commented Apr 22, 2020

belingueres commented Apr 22, 2020 •

edited

Loading

michael-o commented Sep 19, 2021

slawekjaranowski commented Mar 14, 2022

slawekjaranowski commented Mar 14, 2022

slawekjaranowski commented Mar 15, 2022

belingueres commented Mar 16, 2022

slawekjaranowski left a comment

slawekjaranowski left a comment

slawekjaranowski commented Mar 26, 2022

slawekjaranowski commented Mar 27, 2022

slachiewicz commented Mar 27, 2022

slawekjaranowski commented Apr 1, 2022

slawekjaranowski commented Apr 1, 2022

[MNG-5222] - Maven 3 no longer logs warnings about deprecated parameter in plugin #285

[MNG-5222] - Maven 3 no longer logs warnings about deprecated parameter in plugin #285

Conversation

belingueres commented Sep 9, 2019

slachiewicz commented Jan 1, 2020

belingueres commented Jan 2, 2020

slachiewicz commented Jan 2, 2020

rfscholte Jan 2, 2020

Choose a reason for hiding this comment

belingueres Jan 7, 2020

Choose a reason for hiding this comment

hboutemy commented Apr 22, 2020

belingueres commented Apr 22, 2020 • edited Loading

michael-o commented Sep 19, 2021

slawekjaranowski commented Mar 14, 2022

slawekjaranowski commented Mar 14, 2022

slawekjaranowski commented Mar 15, 2022

belingueres commented Mar 16, 2022

slawekjaranowski left a comment

Choose a reason for hiding this comment

slawekjaranowski left a comment

Choose a reason for hiding this comment

slawekjaranowski commented Mar 26, 2022

slawekjaranowski commented Mar 27, 2022

slachiewicz commented Mar 27, 2022

slawekjaranowski commented Apr 1, 2022

slawekjaranowski commented Apr 1, 2022

belingueres commented Apr 22, 2020 •

edited

Loading