-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the same branch name for ITs on Jenkins #1263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The repository needs to be changed to point to the repository that hosts the PR branch.
checkout([$class: 'GitSCM', | ||
branches: [[name: ITS_BRANCH]], | ||
extensions: [[$class: 'CloneOption', depth: 1, noTags: true, shallow: true]], | ||
userRemoteConfigs: [[url: 'https://github.com/apache/maven-integration-testing.git']]]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're still using the maven-integration-testing
GitHub repo, but it needs to point to the same repository from the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't we say earlier to use only master for this build?
Or I'm lost?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, then, what's the point of this PR ? I'm lost too...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jobs on jenkins are not executed for PR from forked repository.
The goal is minimize a failed build PR on jenkins, when we have change in Maven and connected in ITs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also have a https://github.com/apache/maven-integration-testing/tree/maven-3.8.x branch in ITs - so this branch should be used for testing maven-3.8.x and so on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(cherry picked from commit 882c8dd)
(cherry picked from commit 882c8dd)
We have the same logic on GitHub actions.
When branch with the same name as in repository exist in integration test we should use it.