Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUREFIRE-2266] Execute ITs in parallel #781

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

slawekjaranowski
Copy link
Member

We can execute tests in parallel, since we have many fork with new JVM for surefire tests should not interacted during execution.

@slawekjaranowski slawekjaranowski marked this pull request as draft September 20, 2024 07:09
@slawekjaranowski
Copy link
Member Author

On GitHUb it will take about 1 hour instead of 2 ... on Jenkins I also see less time consumption for build

@michael-o
Copy link
Member

Are we sure that all of the test code is thread-safe and does not share any resources on disk?

@slawekjaranowski
Copy link
Member Author

Are we sure that all of the test code is thread-safe and does not share any resources on disk?

In each JVM tests are executed sequentially only one shared resources is local maven repository.

@michael-o
Copy link
Member

Are we sure that all of the test code is thread-safe and does not share any resources on disk?

In each JVM tests are executed sequentially only one shared resources is local maven repository.

Sounds reasonable. Running that too here for testing.

Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on "hw.model: Intel(R) Xeon(R) CPU E5-2640 v4 @ 2.40GHz" I am down to:

[WARNING] Tests run: 1042, Failures: 0, Errors: 0, Skipped: 162
[INFO]
[INFO]
[INFO] --- animal-sniffer-maven-plugin:1.24:check (signature-check) @ surefire-its ---
[INFO] Checking unresolved references to org.codehaus.mojo.signature:java18:1.0
[INFO]
[INFO] --- maven-failsafe-plugin:3.5.0:verify (default) @ surefire-its ---
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache Maven Surefire 3.5.1-SNAPSHOT:
[INFO]
[INFO] Apache Maven Surefire .............................. SUCCESS [  7.949 s]
[INFO] Surefire Shared Utils .............................. SUCCESS [  4.467 s]
[INFO] Surefire Logger API ................................ SUCCESS [  6.380 s]
[INFO] Surefire API ....................................... SUCCESS [ 25.108 s]
[INFO] Surefire Extensions API ............................ SUCCESS [  5.652 s]
[INFO] Surefire Extensions SPI ............................ SUCCESS [  1.964 s]
[INFO] Surefire Booter .................................... SUCCESS [ 18.719 s]
[INFO] Maven Surefire Test-Grouping Support ............... SUCCESS [  5.389 s]
[INFO] Surefire Providers ................................. SUCCESS [  0.823 s]
[INFO] Shared JUnit3 Provider Code ........................ SUCCESS [  3.747 s]
[INFO] Shared Java 5 Provider Base ........................ SUCCESS [  5.330 s]
[INFO] Shared JUnit4 Provider Code ........................ SUCCESS [  4.862 s]
[INFO] Shared JUnit48 Provider Code ....................... SUCCESS [  8.168 s]
[INFO] Surefire JUnit Runner .............................. SUCCESS [  4.689 s]
[INFO] Surefire JUnit4 Runner ............................. SUCCESS [  4.438 s]
[INFO] Maven Surefire Common .............................. SUCCESS [01:12 min]
[INFO] Surefire JUnitCore Runner .......................... SUCCESS [02:12 min]
[INFO] Surefire JUnit Platform Runner ..................... SUCCESS [ 10.352 s]
[INFO] Surefire TestNG Utils .............................. SUCCESS [  4.436 s]
[INFO] Surefire TestNG Runner ............................. SUCCESS [  7.624 s]
[INFO] ShadeFire JUnit3 Provider .......................... SUCCESS [  1.683 s]
[INFO] Surefire Report Parser ............................. SUCCESS [  5.522 s]
[INFO] Maven Surefire Plugin .............................. SUCCESS [  8.808 s]
[INFO] Maven Failsafe Plugin .............................. SUCCESS [ 46.672 s]
[INFO] Maven Surefire Report Plugin ....................... SUCCESS [ 15.820 s]
[INFO] Maven Surefire Integration Tests ................... SUCCESS [22:15 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  29:08 min
[INFO] Finished at: 2024-09-20T10:49:48+02:00
[INFO] ------------------------------------------------------------------------

very nice

@slawekjaranowski slawekjaranowski changed the title Try to execute ITs in parallel [SUREFIRE-2266] Execute ITs in parallel Sep 20, 2024
@slawekjaranowski slawekjaranowski marked this pull request as ready for review September 20, 2024 09:31
@slawekjaranowski slawekjaranowski merged commit 5aa3515 into master Sep 20, 2024
40 checks passed
@slawekjaranowski slawekjaranowski deleted the try-parallel-its branch September 20, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants