-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SUREFIRE-2211] Fix UNC classpath elements #689
Conversation
...rc/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
Show resolved
Hide resolved
...rc/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
Show resolved
Hide resolved
...rc/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
Outdated
Show resolved
Hide resolved
b3ed950
to
189442d
Compare
…with Maven Failsafe Plugin This closes apache#689
189442d
to
07513ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the failing test
07513ba
to
fea8208
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have force-pushed on purpose. You destroyed those changes. Please restore and fix the issue again.
fea8208
to
88c4a0e
Compare
Sorry, I didn't see your changes. I applied this PR's changes to the current master branch (and removed another tab character in my changes, which was interfering with the build before). I hope everything fits now. |
Still not the commit message I have applied. 😁 |
…with Maven Failsafe Plugin This closes apache#689
88c4a0e
to
e8af683
Compare
I've now restored the commit message. |
@robseidel Thanks! Can you have a look why the assumption fails? |
Yeah, I will have a look at it. I want to exclude this test in non Windows environments and thought assumption is the way to go, like at SurefireHelperTest shouldEscapeWindowsPath, but I'm probably missing something. |
Seems like PowerMockRunner does not work with assumptions (powermock/powermock#428). I'll have to find another way to skip the test in a non Windows environment. |
…with Maven Failsafe Plugin This closes apache#689
e8af683
to
a37daf9
Compare
I found a solution for the assumption problem. It works in my environment (changed assumeTrue to assumeFalse), so hopefully the build does run now. |
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
SUREFIRE-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean install
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean install
).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
[] In any other case, please file an Apache Individual Contributor License Agreement.