Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUREFIRE-2211] Fix UNC classpath elements #689

Closed
wants to merge 1 commit into from

Conversation

robseidel
Copy link
Contributor

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@robseidel robseidel requested a review from michael-o November 30, 2023 09:26
michael-o pushed a commit to robseidel/maven-surefire that referenced this pull request Nov 30, 2023
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the failing test

Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have force-pushed on purpose. You destroyed those changes. Please restore and fix the issue again.

@robseidel
Copy link
Contributor Author

Sorry, I didn't see your changes. I applied this PR's changes to the current master branch (and removed another tab character in my changes, which was interfering with the build before). I hope everything fits now.

@michael-o
Copy link
Member

Sorry, I didn't see your changes. I applied this PR's changes to the current master branch (and removed another tab character in my changes, which was interfering with the build before). I hope everything fits now.

Still not the commit message I have applied. 😁

robseidel added a commit to robseidel/maven-surefire that referenced this pull request Dec 4, 2023
@robseidel
Copy link
Contributor Author

I've now restored the commit message.

@michael-o
Copy link
Member

@robseidel Thanks! Can you have a look why the assumption fails?

@robseidel
Copy link
Contributor Author

Yeah, I will have a look at it. I want to exclude this test in non Windows environments and thought assumption is the way to go, like at SurefireHelperTest shouldEscapeWindowsPath, but I'm probably missing something.

@robseidel
Copy link
Contributor Author

robseidel commented Dec 4, 2023

Seems like PowerMockRunner does not work with assumptions (powermock/powermock#428). I'll have to find another way to skip the test in a non Windows environment.

@robseidel
Copy link
Contributor Author

I found a solution for the assumption problem. It works in my environment (changed assumeTrue to assumeFalse), so hopefully the build does run now.
(https://youtrack.jetbrains.com/issue/IDEA-288919/JUnit-4-assumption-throwing-error-instead-of-ignoring-test-when-using-PowerMock-runner)

@michael-o michael-o closed this in 55ccd06 Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants