Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace unsupported <tt> tags in Javadoc comments #392

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

mikemybytes
Copy link
Contributor

When building Surefire with Java 17 (OpenJDK 64-Bit Server VM Temurin-17+35) and Maven 3.6.3, the Javadoc generation process fails with the following error:

[ERROR] /home/mike/Workspace/maven-surefire/surefire-api/src/main/java/org/apache/maven/surefire/api/report/ReportEntry.java:[79,89] error: tag not supported in HTML5: tt

The problem seems not to appear when building the project with Java 11 (OpenJDK 64-Bit Server VM AdoptOpenJDK).

As the <tt> tag seems to be deprecated, it should probably be replaced with an HTML 5-compatible alternative like <code>. This PR introduces such a change.

From the semantical point of view, not every introduced <code> usage represents the actual code. In case it's not desirable to use it like this everywhere, we may consider replacing some of the occurrences with a different tag like <pre>.

@olamy olamy merged commit 970103a into apache:master Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants