Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUREFIRE-1840] Distinguish commands in docs for testing with docker #325

Merged
merged 1 commit into from
Dec 5, 2020

Conversation

mslwang
Copy link
Contributor

@mslwang mslwang commented Dec 1, 2020

sudo, which provides root/ administrator level priviledges on *nix
systems, should be only used when required. Given that docker uses the
kernel of the host system for Linux while docker uses a virtual machine
for Windows/macOS, it is omitted for the latter. This was clarified for
the documentation concerning testing Maven Surefire with docker.

sudo, which provides root/ administrator level priviledges on *nix
systems, should be only used when required. Given that docker uses the
kernel of the host system for Linux while docker uses a virtual machine
for Windows/macOS, it is omitted for the latter. This was clarified for
the documentation concerning testing Maven Surefire with docker.
@mslwang mslwang changed the title [SUREFIRE-1840] Distinguish commands in docs [SUREFIRE-1840] Distinguish commands in docs for testing with docker Dec 3, 2020
@Tibor17 Tibor17 merged commit 9ef0d6e into apache:master Dec 5, 2020
@Tibor17
Copy link
Contributor

Tibor17 commented Dec 5, 2020

Thx for contributing.

@mslwang
Copy link
Contributor Author

mslwang commented Jun 20, 2021

Update: A caveat I've discovered for this with some more exposure to docker is the usage of docker groups to avoid using sudo in Linux. It's a common practice, but not necessarily the safest, so I'm not sure what the best practice would be here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants