[SUREFIRE-1851] Prevent NPE in SmartStackTraceParser #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tibor17
reviewed
Oct 6, 2020
| } | ||
|
|
||
| @Override | ||
| public synchronized Throwable getCause() |
There was a problem hiding this comment.
There is no need for it to be synchronized, good catch. I will remove this.
|
Pls squash the commits finally. Thx. |
Tibor17
reviewed
Oct 6, 2020
| } | ||
|
|
||
| private static List<StackTraceElement> focusOnClass( StackTraceElement[] stackTrace, Class<?> clazz ) | ||
| { | ||
| List<StackTraceElement> result = new ArrayList<>(); | ||
| if ( stackTrace == null ) | ||
| { |
There was a problem hiding this comment.
Pls use Collections.emptyList() instead, and move the ArrayList down. Thx
|
Many thanks for your review 🙌 I believe I have made the required changes, including:
|
|
Thx, lets continue tomorrow morning.
Dňa st 7. 10. 2020, 1:37 Adam Jones <[email protected]> napísal(a):
… Many thanks for your review 🙌
I believe I have made the required changes, including:
- removing unnecessary synchronized
- squashing the commits into one final commit (0505338
<0505338>
)
- moving the array list constructor past the if statement, and using
Collections.emptyList() instead
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#320 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAH7ER2U5XOEAX5YWHX7LATSJOS43ANCNFSM4SEBPILA>
.
|
|
@domdomegg |
|
Thanks for your review and help with this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/SUREFIRE-1851
SmartStackTraceParser is used in various places to parse throwables. However, if the throwable stack trace is null it will throw an NPE itself. This can cause test runners to fail in unexpected ways, which in the worst case can lead to false success test results and passing builds despite the test actually failing.
An exception with a null stacktrace sounds odd, but is easy to do by mocking an exception with frameworks like Mockito. While people probably shouldn't be mocking exceptions, it definitely can and does happen. Can be reproduced with https://github.com/domdomegg/surefire-1851-demo
This is my first PR to the Apache project, apologies if I've gotten anything wrong - I've tried to follow the contributing guidelines as best I can, but do let me know if something needs changing :)