Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRESOLVER-294] Fix JapiCmp configuration and document it #221

Merged
merged 4 commits into from
Nov 13, 2022

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Nov 12, 2022

Fix japicmp configuration and explain what we "promise" to clients and what we "expect" from them.


https://issues.apache.org/jira/browse/MRESOLVER-294

@cstamas cstamas self-assigned this Nov 12, 2022
@cstamas cstamas marked this pull request as ready for review November 12, 2022 17:04
@cstamas cstamas added this to the 1.9.1 milestone Nov 12, 2022
And fix: no need for default interface method on an
interface that is noimplement. Once fixed, the override
can be removed from japicmp config as well.
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit

under the License.
-->

Maven Resolver exposes 3 modules for clients and those extending Maven Resolver:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

three

@cstamas cstamas merged commit 5cfa5be into apache:master Nov 13, 2022
@cstamas cstamas deleted the fix-japicmp branch November 13, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants