[1.6.x][MRESOLVER-235] Fix dependency management issue #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dependency graph # Conflicts: # maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/manager/ClassicDependencyManager.java
|
Resolver has 3 DependencyManager implementations: "classic" (so far all Maven 3+ versions used it), "transitive" (almost same as "classic" sans the 2 depth thing) and "default" (unsure about the intent here). The issue PR would modify the "classic" depMgr, while it would then become (almost) same as "transitive" is. Hence, am rejecting the PR, and the issue altogether, as to me this seems like just a need for another depMgr exposed in Maven? See: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a fix for MRESOLVER-235 / MNG-7003.
However, the fix breaks two ITs: mng4720 and mng4396.
For mng4720, so core of the IT is not broken, but as specifically commented in the IT see https://github.com/apache/maven-integration-testing/blob/master/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4720DependencyManagementExclusionMergeTest.java#L70, one of the dependency is not included anymore.
The PR contains unit tests that replicate the ITs for mng4720 and for MNG-7003 (available at https://github.com/gnodet/maven-integration-testing/tree/MNG-7003). I'm not sure there's any way to fix both at the same time.