[MRRESOURCES-150] Ensure reproducible order in bundle

[adoroszlai]

What changes were proposed in this pull request?

remote-resources:bundle creates output that may not be reproducible.

maven-remote-resources-plugin/src/main/java/org/apache/maven/plugin/resources/remote/BundleRemoteResourcesMojo.java

Lines 108 to 122 in 7a40047

	DirectoryScanner scanner = new DirectoryScanner();
	scanner.setBasedir(resourcesDirectory);
	if (includes != null && includes.length != 0) {
	scanner.setIncludes(includes);
	} else {
	scanner.setIncludes(DEFAULT_INCLUDES);
	}
	if (excludes != null && excludes.length != 0) {
	scanner.setExcludes(excludes);
	}
	scanner.addDefaultExcludes();
	scanner.scan();

DirectoryScanner uses java.io.File.list(), which does not guarantee order.

https://issues.apache.org/jira/browse/MRESOURCES-311

How was this patch tested?

Built the plugin and used it in another project. Changed naturalOrder to reverseOrder, and repeated. Verified output is reversed between the two runs.

[adoroszlai]

@elharo @slawekjaranowski please review when you have some time

[elharo]

Test?

[slawekjaranowski]

I moved issue to correct jira project - https://issues.apache.org/jira/browse/MRRESOURCES-150
please update commit message and PR title

[adoroszlai]

Test?

Added.

I moved issue to correct jira project

Thanks.

please update commit message and PR title

PR title updated.

Would you like me to squash commits and force-push?

[slawekjaranowski]

Would you like me to squash commits and force-push?

I can squash ....

[elharo]

These days we're using Hamcrest, not assertj

[slawekjaranowski]

It is only test dependencies .... I will not require
even more JUnit 5 doesn't use it

[elharo]

I'd like to settle on one thing. I don't care much which one, but let's not have a random mix of libraries doing the same thing.

[slawekjaranowski]

we didn't use any Hamcrest nor assertj until this PR
@elharo any other remarks?

[elharo]

My impression is that across Maven and even more broadly across Java, but definitely within Maven hamcrest is far more common now. I've certainly seen it a lot more while working my way through all the plugins than I've seen assert4j, though they are both present. JUnit 4 already depends on Hamcrest, though that got removed in JUnit 5.

[slawekjaranowski]

ok we have Hamcrest so I would like to merge

[slawekjaranowski]

@adoroszlai thanks

[adoroszlai]

Thanks @elharo, @slawekjaranowski for the review.