Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPIR-451] Rename "Dependency Information" to "Maven Coordinates" #67

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

michael-o
Copy link
Member

This closes #67

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MPIR-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MPIR-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@michael-o
Copy link
Member Author

Note from me: I agree with @elharo's sentiments that this goal is incorrently named. I lines up with the other dependency goals which are about the project's deps and not about this project being a dep somewhere.

src/main/resources/project-info-reports_fr.properties Outdated Show resolved Hide resolved
@@ -44,8 +44,8 @@ ${project.name}
* {{{./dependency-convergence-mojo.html}project-info-reports:dependency-convergence}} is used to generate the
Project Dependency Convergence report for (reactor) builds.

* {{{./dependency-info-mojo.html}project-info-reports:dependency-info}} is used to generate code snippets to
be added to build tools.
* {{{./dependency-info-mojo.html}project-info-reports:dependency-info}} is used to generate code snippets
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is used to generate --> generates

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This goes throughout all bulletpoints. I'd leave as is and do this in another PR.

src/site/apt/index.apt.vm Outdated Show resolved Hide resolved
src/site/apt/index.apt.vm Outdated Show resolved Hide resolved
asfgit pushed a commit that referenced this pull request Jun 2, 2024
@michael-o michael-o requested a review from elharo June 2, 2024 12:44
@asfgit asfgit closed this in be2e4ed Jun 4, 2024
@asfgit asfgit merged commit be2e4ed into master Jun 4, 2024
4 of 23 checks passed
@michael-o michael-o deleted the MPIR-451 branch June 4, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants