[MNG-7416] Simplify Boolean expressions and returns (#63)

Use this link to re-run the recipe: https://app.moderne.io/recipes/builder/SEvWu02zw?organizationId=QXBhY2hlIE1hdmVu Co-authored-by: Moderne <[email protected]>
apache · Sep 26, 2023 · c16ec94 · c16ec94
1 parent abd0e76
commit c16ec94
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 13 deletions.
diff --git a/src/main/java/org/apache/maven/report/projectinfo/ScmReport.java b/src/main/java/org/apache/maven/report/projectinfo/ScmReport.java
@@ -817,12 +817,7 @@ private static boolean isScmSystem(ScmRepository scmRepository, String scmProvid
             if (scmProvider == null || scmProvider.isEmpty()) {
                 return false;
             }
-
-            if (scmRepository != null && scmProvider.equalsIgnoreCase(scmRepository.getProvider())) {
-                return true;
-            }
-
-            return false;
+            return scmRepository != null && scmProvider.equalsIgnoreCase(scmRepository.getProvider());
         }
     }
 }
diff --git a/src/main/java/org/apache/maven/report/projectinfo/SummaryReport.java b/src/main/java/org/apache/maven/report/projectinfo/SummaryReport.java
@@ -225,11 +225,7 @@ private boolean isJavaProject(MavenProject project) {
             // maven-compiler-plugin ?
             Xpp3Dom pluginConfig =
                     project.getGoalConfiguration("org.apache.maven.plugins", "maven-compiler-plugin", null, null);
-            if (pluginConfig != null) {
-                return true;
-            }
-
-            return false;
+            return pluginConfig != null;
         }
     }
 }
diff --git a/.../java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java b/.../java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java
@@ -896,7 +896,7 @@ private void printDependencyListing(DependencyNode node) {
 
         if (!node.getChildren().isEmpty()) {
             boolean toBeIncluded = false;
-            List<DependencyNode> subList = new ArrayList<DependencyNode>();
+            List<DependencyNode> subList = new ArrayList<>();
             for (DependencyNode dep : node.getChildren()) {
                 if (dependencies.getAllDependencies().contains(dep.getArtifact())) {
                     subList.add(dep);

diff --git a/src/test/java/org/apache/maven/report/projectinfo/ProjectInfoReportUtilsTest.java b/src/test/java/org/apache/maven/report/projectinfo/ProjectInfoReportUtilsTest.java
@@ -60,7 +60,7 @@ public class ProjectInfoReportUtilsTest extends AbstractMojoTestCase {
     protected void setUp() throws Exception {
         super.setUp();
 
-        final List<org.apache.maven.settings.Server> servers = new ArrayList<org.apache.maven.settings.Server>();
+        final List<org.apache.maven.settings.Server> servers = new ArrayList<>();
         org.apache.maven.settings.Server server = new org.apache.maven.settings.Server();
         server.setId("localhost");
         server.setUsername("admin");